Leverage ReflectionFunction::isAnonymous()

Author: nicolas-grekas

src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/JsonDescriptor.php

@@ -393,7 +393,7 @@ private function getCallableData(mixed $callable): array
             $data['type'] = 'closure';
 
             $r = new \ReflectionFunction($callable);
-            if (str_contains($r->name, '{closure}')) {
+            if ($r->isAnonymous()) {
                 return $data;
             }
             $data['name'] = $r->name;

src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/MarkdownDescriptor.php

@@ -403,7 +403,7 @@ protected function describeCallable(mixed $callable, array $options = []): void
             $string .= "\n- Type: `closure`";
 
             $r = new \ReflectionFunction($callable);
-            if (str_contains($r->name, '{closure}')) {
+            if ($r->isAnonymous()) {
                 $this->write($string."\n");
 
                 return;

src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php

@@ -649,7 +649,7 @@ private function formatCallable(mixed $callable): string
 
         if ($callable instanceof \Closure) {
             $r = new \ReflectionFunction($callable);
-            if (str_contains($r->name, '{closure}')) {
+            if ($r->isAnonymous()) {
                 return 'Closure()';
             }
             if ($class = $r->getClosureCalledClass()) {

src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/XmlDescriptor.php

@@ -581,7 +581,7 @@ private function getCallableDocument(mixed $callable): \DOMDocument
             $callableXML->setAttribute('type', 'closure');
 
             $r = new \ReflectionFunction($callable);
-            if (str_contains($r->name, '{closure}')) {
+            if ($r->isAnonymous()) {
                 return $dom;
             }
             $callableXML->setAttribute('name', $r->name);

src/Symfony/Bundle/FrameworkBundle/Kernel/MicroKernelTrait.php

@@ -214,7 +214,7 @@ public function loadRoutes(LoaderInterface $loader): RouteCollection
 
             if (\is_array($controller) && [0, 1] === array_keys($controller) && $this === $controller[0]) {
                 $route->setDefault('_controller', ['kernel', $controller[1]]);
-            } elseif ($controller instanceof \Closure && $this === ($r = new \ReflectionFunction($controller))->getClosureThis() && !str_contains($r->name, '{closure}')) {
+            } elseif ($controller instanceof \Closure && $this === ($r = new \ReflectionFunction($controller))->getClosureThis() && !$r->isAnonymous()) {
                 $route->setDefault('_controller', ['kernel', $r->name]);
             }
         }

src/Symfony/Bundle/SecurityBundle/Command/DebugFirewallCommand.php

@@ -238,7 +238,7 @@ private function formatCallable(mixed $callable): string
 
         if ($callable instanceof \Closure) {
             $r = new \ReflectionFunction($callable);
-            if (str_contains($r->name, '{closure}')) {
+            if ($r->isAnonymous()) {
                 return 'Closure()';
             }
             if ($class = $r->getClosureCalledClass()) {

src/Symfony/Component/EventDispatcher/Debug/WrappedListener.php

@@ -48,7 +48,7 @@ public function __construct(callable|array $listener, ?string $name, Stopwatch $
             $this->callableRef .= '::'.$listener[1];
         } elseif ($listener instanceof \Closure) {
             $r = new \ReflectionFunction($listener);
-            if (str_contains($r->name, '{closure}')) {
+            if ($r->isAnonymous()) {
                 $this->pretty = $this->name = 'closure';
             } elseif ($class = $r->getClosureCalledClass()) {
                 $this->name = $class->name;

src/Symfony/Component/HttpKernel/Controller/ControllerResolver.php

@@ -240,7 +240,7 @@ private function checkController(Request $request, callable $controller): callab
             $r = new \ReflectionFunction($controller);
             $name = $r->name;
 
-            if (str_contains($name, '{closure}')) {
+            if ($r->isAnonymous()) {
                 $name = $class = \Closure::class;
             } elseif ($class = $r->getClosureCalledClass()) {
                 $class = $class->name;

src/Symfony/Component/HttpKernel/DataCollector/RequestDataCollector.php

@@ -469,7 +469,7 @@ private function parseController(array|object|string|null $controller): array|st
                 'line' => $r->getStartLine(),
             ];
 
-            if (str_contains($r->name, '{closure}')) {
+            if ($r->isAnonymous()) {
                 return $controller;
             }
             $controller['method'] = $r->name;

src/Symfony/Component/HttpKernel/Event/ControllerEvent.php

@@ -98,7 +98,7 @@ public function getAttributes(string $className = null): array
         } elseif (\is_string($this->controller) && false !== $i = strpos($this->controller, '::')) {
             $class = new \ReflectionClass(substr($this->controller, 0, $i));
         } else {
-            $class = str_contains($this->controllerReflector->name, '{closure}') ? null : $this->controllerReflector->getClosureCalledClass();
+            $class = $this->controllerReflector instanceof \ReflectionFunction && $this->controllerReflector->isAnonymous() ? null : $this->controllerReflector->getClosureCalledClass();
         }
         $this->attributes = [];