minor symfony#52505 [String] remove error handler not needed on PHP 8 (xabbuh)

This PR was merged into the 6.4 branch.

Discussion
----------

[String] remove error handler not needed on PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Commits
-------

b95f7fc remove error handler not needed on PHP 8

Author: nicolas-grekas

src/Symfony/Component/String/AbstractString.php

@@ -507,23 +507,14 @@ public function toByteString(string $toEncoding = null): ByteString
             return $b;
         }
 
-        set_error_handler(static fn ($t, $m) => throw new InvalidArgumentException($m));
-
         try {
-            try {
-                $b->string = mb_convert_encoding($this->string, $toEncoding, 'UTF-8');
-            } catch (InvalidArgumentException|\ValueError $e) {
-                if (!\function_exists('iconv')) {
-                    if ($e instanceof \ValueError) {
-                        throw new InvalidArgumentException($e->getMessage(), $e->getCode(), $e);
-                    }
-                    throw $e;
-                }
-
-                $b->string = iconv('UTF-8', $toEncoding, $this->string);
+            $b->string = mb_convert_encoding($this->string, $toEncoding, 'UTF-8');
+        } catch (\ValueError $e) {
+            if (!\function_exists('iconv')) {
+                throw new InvalidArgumentException($e->getMessage(), $e->getCode(), $e);
             }
-        } finally {
-            restore_error_handler();
+
+            $b->string = iconv('UTF-8', $toEncoding, $this->string);
         }
 
         return $b;