Commit 1f64ca9
committed
minor symfony#61681 [Intl] Remove incorrect condition in
This PR was merged into the 6.4 branch.
Discussion
----------
[Intl] Remove incorrect condition in `CurrencyDataGenerator::icuPairToDate`
| Q | A
| ------------- | ---
| Branch? | 6.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Issues | Fix symfony#61556 (comment)
| License | MIT
Remove a useless condition that breaks psalm analysis.
- `1 << 63 === PHP_INT_MIN` we cannot have a lower int value
- `1 << 64 === 0` so the removing this value doesn't change anything
Fix psalm crash due to bug vimeo/psalm#11209
When `PHP_INT_MIN - 1`, the value is converted to a float that breaks the type system of psalm https://github.com/vimeo/psalm/blob/279f3eab037923d3f9d3ea3de1a16b425653e30c/src/Psalm/Internal/Type/SimpleAssertionReconciler.php#L2073
Dealing with timestamp `>= (1 << 62)/1000` will be necessary when we read [year 146140482](https://3v4l.org/AAKNt).
Commits
-------
7779ac1 [Intl] Remove incorrect condition in CurrencyDataGenerator::icuPairToDateCurrencyDataGenerator::icuPairToDate (GromNaN)File tree
1 file changed
+0
-5
lines changed- src/Symfony/Component/Intl/Data/Generator
1 file changed
+0
-5
lines changedLines changed: 0 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
236 | 236 | | |
237 | 237 | | |
238 | 238 | | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | 239 | | |
245 | 240 | | |
246 | 241 | | |
| |||
0 commit comments