Commit 27bc8d6
committed
bug symfony#52978 [Webhook] [Framework] Added missing XML attribute in config XSD (TimoBakx)
This PR was merged into the 6.3 branch.
Discussion
----------
[Webhook] [Framework] Added missing XML attribute in config XSD
| Q | A
| ------------- | ---
| Branch? | 6.3
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Issues |
| License | MIT
The XML schema definition was missing the type attribute for the webhook routing.
This attribute is necessary to identify the correct parser and remote event consumers.
In YAML and PHP, it exists and works:
```yaml
framework:
webhook:
routing:
mailer: # <-- this identifier
service: #...
secret: #...
```
```php
use App\Webhook\MailerWebhookParser;
use Symfony\Config\FrameworkConfig;
return static function (FrameworkConfig $frameworkConfig): void {
$webhookConfig = $frameworkConfig->webhook();
$webhookConfig
->routing('mailer') // <-- this parameter
->service('mailer.webhook.request_parser.mailgun')
->secret('%env(MAILER_MAILGUN_SECRET)%')
;
};
```
#SymfonyHackday
Commits
-------
43b0877 [Webhook] Added missing XML attribute in config XSDFile tree
1 file changed
+1
-0
lines changed- src/Symfony/Bundle/FrameworkBundle/Resources/config/schema
1 file changed
+1
-0
lines changedLines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
976 | 976 | | |
977 | 977 | | |
978 | 978 | | |
| 979 | + | |
979 | 980 | | |
980 | 981 | | |
981 | 982 | | |
| |||
0 commit comments