minor symfony#59127 [Console] fix risky test that doesn't perform any assertions (xabbuh)

nicolas-grekas · nicolas-grekas · commit 2e1a6287dc16 · 2024-12-07T15:08:40.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [Console] fix risky test that doesn't perform any assertions | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- 4cca70b fix risky test that doesn't perform any assertions
diff --git a/src/Symfony/Component/Console/Tests/Helper/ProgressBarTest.php b/src/Symfony/Component/Console/Tests/Helper/ProgressBarTest.php
@@ -112,8 +112,10 @@ public function testRegularTimeEstimation()
 
     public function testRegularTimeRemainingWithDifferentStartAtAndCustomDisplay()
     {
+        $this->expectNotToPerformAssertions();
+
         ProgressBar::setFormatDefinition('custom', ' %current%/%max% [%bar%] %percent:3s%% %remaining% %estimated%');
-        $bar = new ProgressBar($output = $this->getOutputStream(), 1_200, 0);
+        $bar = new ProgressBar($this->getOutputStream(), 1_200, 0);
         $bar->setFormat('custom');
         $bar->start(1_200, 600);
     }

Original file line number	Diff line number	Diff line change
`@@ -112,8 +112,10 @@ public function testRegularTimeEstimation()`
`112`	`112`
`113`	`113`	`public function testRegularTimeRemainingWithDifferentStartAtAndCustomDisplay()`
`114`	`114`	`{`
	`115`	`+ $this->expectNotToPerformAssertions();`
	`116`	`+`
`115`	`117`	`ProgressBar::setFormatDefinition('custom', ' %current%/%max% [%bar%] %percent:3s%% %remaining% %estimated%');`
`116`		`- $bar = new ProgressBar($output = $this->getOutputStream(), 1_200, 0);`
	`118`	`+ $bar = new ProgressBar($this->getOutputStream(), 1_200, 0);`
`117`	`119`	`$bar->setFormat('custom');`
`118`	`120`	`$bar->start(1_200, 600);`
`119`	`121`	`}`