bug symfony#59840 Fix PHP warning in GetSetMethodNormalizer when a "set()" method is defined (Pepperoni1337)

nicolas-grekas · nicolas-grekas · commit 3a53992068c8 · 2025-02-24T09:43:17.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- Fix PHP warning in GetSetMethodNormalizer when a "set()" method is defined | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Fix: Add length check for setter method detection in src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php Commits ------- 04ff18d Update GetSetMethodNormalizer.php
diff --git a/src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php
@@ -118,6 +118,7 @@ private function isSetMethod(\ReflectionMethod $method): bool
         return !$method->isStatic()
             && !$method->getAttributes(Ignore::class)
             && 0 < $method->getNumberOfParameters()
+            && 3 < \strlen($method->name)
             && str_starts_with($method->name, 'set')
             && !ctype_lower($method->name[3])
             ;

Original file line number	Diff line number	Diff line change
`@@ -118,6 +118,7 @@ private function isSetMethod(\ReflectionMethod $method): bool`
`118`	`118`	`return !$method->isStatic()`
`119`	`119`	`&& !$method->getAttributes(Ignore::class)`
`120`	`120`	`&& 0 < $method->getNumberOfParameters()`
	`121`	`+ && 3 < \strlen($method->name)`
`121`	`122`	`&& str_starts_with($method->name, 'set')`
`122`	`123`	`&& !ctype_lower($method->name[3])`
`123`	`124`	`;`