[CssSelector][Serializer][Translation] [Command] Clean unused code

Author: alamirault

src/Symfony/Component/Console/Command/Command.php

@@ -277,10 +277,6 @@ public function run(InputInterface $input, OutputInterface $output): int
             $statusCode = ($this->code)($input, $output);
         } else {
             $statusCode = $this->execute($input, $output);
-
-            if (!\is_int($statusCode)) {
-                throw new \TypeError(sprintf('Return value of "%s::execute()" must be of the type int, "%s" returned.', static::class, get_debug_type($statusCode)));
-            }
         }
 
         return is_numeric($statusCode) ? (int) $statusCode : 0;

src/Symfony/Component/CssSelector/XPath/XPathExpr.php

@@ -104,7 +104,7 @@ public function join(string $combiner, self $expr): static
     public function __toString(): string
     {
         $path = $this->path.$this->element;
-        $condition = null === $this->condition || '' === $this->condition ? '' : '['.$this->condition.']';
+        $condition = '' === $this->condition ? '' : '['.$this->condition.']';
 
         return $path.$condition;
     }

src/Symfony/Component/Serializer/Encoder/XmlEncoder.php

@@ -200,13 +200,9 @@ final protected function appendCData(\DOMNode $node, string $val): bool
 
     final protected function appendDocumentFragment(\DOMNode $node, \DOMDocumentFragment $fragment): bool
     {
-        if ($fragment instanceof \DOMDocumentFragment) {
-            $node->appendChild($fragment);
+        $node->appendChild($fragment);
 
-            return true;
-        }
-
-        return false;
+        return true;
     }
 
     final protected function appendComment(\DOMNode $node, string $data): bool

src/Symfony/Component/Translation/Bridge/Crowdin/CrowdinProvider.php

@@ -176,10 +176,6 @@ public function delete(TranslatorBagInterface $translatorBag): void
 
         $defaultCatalogue = $translatorBag->getCatalogue($this->defaultLocale);
 
-        if (!$defaultCatalogue) {
-            $defaultCatalogue = $translatorBag->getCatalogues()[0];
-        }
-
         foreach ($defaultCatalogue->all() as $domain => $messages) {
             $fileId = $this->getFileIdByDomain($fileList, $domain);
 

src/Symfony/Component/Translation/Bridge/Loco/LocoProvider.php

@@ -57,10 +57,6 @@ public function write(TranslatorBagInterface $translatorBag): void
     {
         $catalogue = $translatorBag->getCatalogue($this->defaultLocale);
 
-        if (!$catalogue) {
-            $catalogue = $translatorBag->getCatalogues()[0];
-        }
-
         foreach ($catalogue->all() as $domain => $messages) {
             $createdIds = $this->createAssets(array_keys($messages), $domain);
             if ($createdIds) {
@@ -175,10 +171,6 @@ public function delete(TranslatorBagInterface $translatorBag): void
     {
         $catalogue = $translatorBag->getCatalogue($this->defaultLocale);
 
-        if (!$catalogue) {
-            $catalogue = $translatorBag->getCatalogues()[0];
-        }
-
         $responses = [];
 
         foreach (array_keys($catalogue->all()) as $domain) {

src/Symfony/Component/Translation/Bridge/Lokalise/LokaliseProvider.php

@@ -61,10 +61,6 @@ public function write(TranslatorBagInterface $translatorBag): void
     {
         $defaultCatalogue = $translatorBag->getCatalogue($this->defaultLocale);
 
-        if (!$defaultCatalogue) {
-            $defaultCatalogue = $translatorBag->getCatalogues()[0];
-        }
-
         $this->ensureAllLocalesAreCreated($translatorBag);
         $existingKeysByDomain = [];
 
@@ -111,10 +107,6 @@ public function delete(TranslatorBagInterface $translatorBag): void
     {
         $catalogue = $translatorBag->getCatalogue($this->defaultLocale);
 
-        if (!$catalogue) {
-            $catalogue = $translatorBag->getCatalogues()[0];
-        }
-
         $keysIds = [];
 
         foreach ($catalogue->getDomains() as $domain) {

src/Symfony/Component/Translation/Command/TranslationPushCommand.php

@@ -60,7 +60,7 @@ public function complete(CompletionInput $input, CompletionSuggestions $suggesti
         if ($input->mustSuggestOptionValuesFor('domains')) {
             $provider = $this->providers->get($input->getArgument('provider'));
 
-            if ($provider && method_exists($provider, 'getDomains')) {
+            if (method_exists($provider, 'getDomains')) {
                 $domains = $provider->getDomains();
                 $suggestions->suggestValues($domains);
             }

src/Symfony/Component/Translation/Formatter/MessageFormatter.php

@@ -36,11 +36,7 @@ public function __construct(TranslatorInterface $translator = null, IntlFormatte
 
     public function format(string $message, string $locale, array $parameters = []): string
     {
-        if ($this->translator instanceof TranslatorInterface) {
-            return $this->translator->trans($message, $parameters, null, $locale);
-        }
-
-        return strtr($message, $parameters);
+        return $this->translator->trans($message, $parameters, null, $locale);
     }
 
     public function formatIntl(string $message, string $locale, array $parameters = []): string