minor symfony#53073 Set strict parameter of in_array to true where possible (alexandre-daubois)

This PR was merged into the 7.1 branch.

Discussion
----------

Set `strict` parameter of `in_array` to true where possible

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

This pull request introduces a comprehensive update where the `in_array` function is now consistently invoked with the `strict` parameter set to `true`. This change is implemented across various components of the framework to enhance type safety and reliability.

To me, this update is a step towards more explicit and error-resistant code.

Commits
-------

442329a Set `strict` parameter of `in_array` to true where possible

Author: nicolas-grekas

src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php

@@ -223,8 +223,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                     }
                 }
 
-                if (!\in_array(self::MESSAGE_UNUSED, $states) && $input->getOption('only-unused')
-                    || !\in_array(self::MESSAGE_MISSING, $states) && $input->getOption('only-missing')
+                if (!\in_array(self::MESSAGE_UNUSED, $states, true) && $input->getOption('only-unused')
+                    || !\in_array(self::MESSAGE_MISSING, $states, true) && $input->getOption('only-missing')
                 ) {
                     continue;
                 }

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/UnusedTagsPass.php

@@ -110,7 +110,7 @@ public function process(ContainerBuilder $container): void
 
         foreach ($container->findUnusedTags() as $tag) {
             // skip known tags
-            if (\in_array($tag, self::KNOWN_TAGS)) {
+            if (\in_array($tag, self::KNOWN_TAGS, true)) {
                 continue;
             }
 

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php

@@ -435,7 +435,7 @@ private function addWorkflowSection(ArrayNodeDefinition $rootNode): void
                                                     if (!\is_string($value)) {
                                                         return true;
                                                     }
-                                                    if (class_exists(WorkflowEvents::class) && !\in_array($value, WorkflowEvents::ALIASES)) {
+                                                    if (class_exists(WorkflowEvents::class) && !\in_array($value, WorkflowEvents::ALIASES, true)) {
                                                         return true;
                                                     }
                                                 }

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

@@ -2179,7 +2179,7 @@ private function registerMessengerConfiguration(array $config, ContainerBuilder
                 ->setArguments([$transport['dsn'], $transport['options'] + ['transport_name' => $name], new Reference($serializerId)])
                 ->addTag('messenger.receiver', [
                         'alias' => $name,
-                        'is_failure_transport' => \in_array($name, $failureTransports),
+                        'is_failure_transport' => \in_array($name, $failureTransports, true),
                     ]
                 )
             ;

src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php

@@ -64,7 +64,7 @@ private function addFormThemesSection(ArrayNodeDefinition $rootNode): void
                     ->prototype('scalar')->defaultValue('form_div_layout.html.twig')->end()
                     ->example(['@My/form.html.twig'])
                     ->validate()
-                        ->ifTrue(fn ($v) => !\in_array('form_div_layout.html.twig', $v))
+                        ->ifTrue(fn ($v) => !\in_array('form_div_layout.html.twig', $v, true))
                         ->then(fn ($v) => array_merge(['form_div_layout.html.twig'], $v))
                     ->end()
                 ->end()

src/Symfony/Component/Console/Application.php

@@ -716,7 +716,7 @@ public function find(string $name): Command
 
                 $aliases[$nameOrAlias] = $commandName;
 
-                return $commandName === $nameOrAlias || !\in_array($commandName, $commands);
+                return $commandName === $nameOrAlias || !\in_array($commandName, $commands, true);
             }));
         }
 

src/Symfony/Component/Console/Descriptor/ReStructuredTextDescriptor.php

@@ -226,7 +226,7 @@ private function getNonDefaultOptions(InputDefinition $definition): array
         $nonDefaultOptions = [];
         foreach ($definition->getOptions() as $option) {
             // Skip global options.
-            if (!\in_array($option->getName(), $globalOptions)) {
+            if (!\in_array($option->getName(), $globalOptions, true)) {
                 $nonDefaultOptions[] = $option;
             }
         }

src/Symfony/Component/Console/Helper/TableCellStyle.php

@@ -67,7 +67,7 @@ public function getTagOptions(): array
     {
         return array_filter(
             $this->getOptions(),
-            fn ($key) => \in_array($key, self::TAG_OPTIONS) && isset($this->options[$key]),
+            fn ($key) => \in_array($key, self::TAG_OPTIONS, true) && isset($this->options[$key]),
             \ARRAY_FILTER_USE_KEY
         );
     }

src/Symfony/Component/CssSelector/Parser/Token.php

@@ -72,7 +72,7 @@ public function isDelimiter(array $values = []): bool
             return true;
         }
 
-        return \in_array($this->value, $values);
+        return \in_array($this->value, $values, true);
     }
 
     public function isWhitespace(): bool

src/Symfony/Component/DependencyInjection/Compiler/RegisterEnvVarProcessorsPass.php

@@ -65,7 +65,7 @@ private static function validateProvidedTypes(string $types, string $class): arr
         $types = explode('|', $types);
 
         foreach ($types as $type) {
-            if (!\in_array($type, self::ALLOWED_TYPES)) {
+            if (!\in_array($type, self::ALLOWED_TYPES, true)) {
                 throw new InvalidArgumentException(sprintf('Invalid type "%s" returned by "%s::getProvidedTypes()", expected one of "%s".', $type, $class, implode('", "', self::ALLOWED_TYPES)));
             }
         }