minor symfony#59995 [Config] Make ifFalse() consistent between value and closure based checks (arjenm)

This PR was squashed before being merged into the 7.3 branch.

Discussion
----------

[Config] Make ifFalse() consistent between value and closure based checks

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix  symfony#59325
| License       | MIT

I noticed the Config/ExpBuilder got a nice new ifFalse in Symfony 7.3.
But I think its implementation is confusing.

The behavior for `ifTrue()` was:
- If no closure is provided: if the actual value is `true` execute the then part
- If a closure is provided: if it returns `true` execute the then part

The behavior for `ifFalse()` is prior to this PR is:
- If no closure is provided: if the actual value is `false` execute the then part
- If a closure is provided: if it returns **`true`** execute the then part

With this PR it becomes:
- If no closure is provided: if the actual value is `false` execute the then part
- If a closure is provided: if it returns **`false`** execute the then part

Rationale, I think people (me included) would not expect these to be both be valid or invalid with the same input:
`$expr->ifTrue(self::valueIsNotValid(...))->thenInvalid()`
`$expr->ifFalse(self::valueIsNotValid(...))->thenInvalid()`

They/I expect to have to change it to a test for valid values (rather than invalid ones):
`$expr->ifFalse(self::valueIsValid(...))->thenInvalid()`

Commits
-------

335bdbe [Config] Make ifFalse() consistent between value and closure based checks

Author: nicolas-grekas

src/Symfony/Component/Config/Definition/Builder/ExprBuilder.php

@@ -76,7 +76,7 @@ public function ifTrue(?\Closure $closure = null): static
      */
     public function ifFalse(?\Closure $closure = null): static
     {
-        $this->ifPart = $closure ?? static fn ($v) => false === $v;
+        $this->ifPart = $closure ? static fn ($v) => !$closure($v) : static fn ($v) => false === $v;
         $this->allowedTypes = self::TYPE_ANY;
 
         return $this;

src/Symfony/Component/Config/Tests/Definition/Builder/ExprBuilderTest.php

@@ -42,11 +42,23 @@ public function testIfTrueExpression()
         ->end();
         $this->assertFinalizedValueIs('new_value', $test);
 
+        $test = $this->getTestBuilder()
+            ->ifTrue(fn () => 1)
+            ->then($this->returnClosure('new_value'))
+        ->end();
+        $this->assertFinalizedValueIs('new_value', $test);
+
         $test = $this->getTestBuilder()
             ->ifTrue(fn () => false)
             ->then($this->returnClosure('new_value'))
         ->end();
         $this->assertFinalizedValueIs('value', $test);
+
+        $test = $this->getTestBuilder()
+            ->ifTrue(fn () => 0)
+            ->then($this->returnClosure('new_value'))
+        ->end();
+        $this->assertFinalizedValueIs('value', $test);
     }
 
     public function testIfFalseExpression()
@@ -58,16 +70,28 @@ public function testIfFalseExpression()
         $this->assertFinalizedValueIs('new_value', $test, ['key' => false]);
 
         $test = $this->getTestBuilder()
-            ->ifFalse(fn () => true)
+            ->ifFalse(fn ($v) => 'value' === $v)
             ->then($this->returnClosure('new_value'))
         ->end();
-        $this->assertFinalizedValueIs('new_value', $test);
+        $this->assertFinalizedValueIs('value', $test);
 
         $test = $this->getTestBuilder()
-            ->ifFalse(fn () => false)
+            ->ifFalse(fn ($v) => 1)
             ->then($this->returnClosure('new_value'))
         ->end();
         $this->assertFinalizedValueIs('value', $test);
+
+        $test = $this->getTestBuilder()
+            ->ifFalse(fn ($v) => 'other_value' === $v)
+            ->then($this->returnClosure('new_value'))
+        ->end();
+        $this->assertFinalizedValueIs('new_value', $test);
+
+        $test = $this->getTestBuilder()
+            ->ifFalse(fn ($v) => 0)
+            ->then($this->returnClosure('new_value'))
+            ->end();
+        $this->assertFinalizedValueIs('new_value', $test);
     }
 
     public function testIfStringExpression()