bug symfony#59779 [DomCrawler] Bug symfony#43921 Check for null parent nodes in the case of orphaned branches (ttk)

fabpot · fabpot · commit 5c8c72b6dec5 · 2025-02-14T18:58:40.000+01:00
This PR was submitted for the 7.2 branch but it was merged into the 6.4 branch instead. Discussion ---------- [DomCrawler] Bug symfony#43921 Check for null parent nodes in the case of orphaned branches | Q | A | ------------- | --- | Branch | 7.2 | Bug fix | yes | New feature | no | Deprecations | no | Issues | Fix symfony#43921 | License | MIT This simple fix checks for null parent nodes when traversing the DOM tree when calling the `closest()` function. Instead of failing, the function will return null instead. This bring it into alignment with how the `ancestors()` function behaves (not failing on null parent nodes). Null parent nodes can occur when a DOM branch is orphaned due to manipulations on the document, and this is a perfectly normal scenario. Unit tests added that checks for this specific bug. This fix should not break any backward compatibility. Commits ------- 9a98452 Check for null parent Nodes in the case of orphaned branches
diff --git a/src/Symfony/Component/DomCrawler/Crawler.php b/src/Symfony/Component/DomCrawler/Crawler.php
@@ -431,7 +431,7 @@ public function closest(string $selector): ?self
 
         $domNode = $this->getNode(0);
 
-        while (\XML_ELEMENT_NODE === $domNode->nodeType) {
+        while (null !== $domNode && \XML_ELEMENT_NODE === $domNode->nodeType) {
             $node = $this->createSubCrawler($domNode);
             if ($node->matches($selector)) {
                 return $node;
diff --git a/src/Symfony/Component/DomCrawler/Tests/AbstractCrawlerTestCase.php b/src/Symfony/Component/DomCrawler/Tests/AbstractCrawlerTestCase.php
@@ -1031,6 +1031,29 @@ public function testClosest()
         $this->assertNull($notFound);
     }
 
+    public function testClosestWithOrphanedNode()
+    {
+        $html = <<<'HTML'
+<html lang="en">
+<body>
+    <div id="foo" class="newFoo ok">
+        <div class="lorem1 ko"></div>
+    </div>
+</body>
+</html>
+HTML;
+
+        $crawler = $this->createCrawler($this->getDoctype().$html);
+        $foo = $crawler->filter('#foo');
+
+        $fooNode = $foo->getNode(0);
+
+        $fooNode->parentNode->replaceChild($fooNode->ownerDocument->createElement('ol'), $fooNode);
+
+        $body = $foo->closest('body');
+        $this->assertNull($body);
+    }
+
     public function testOuterHtml()
     {
         $html = <<<'HTML'
