Commit 7be1c03
committed
bug symfony#51821 Add test for 0 and '0' in PeriodicalTrigger and fix '0' case error (ardentsword)
This PR was merged into the 6.4 branch.
Discussion
----------
Add test for 0 and '0' in PeriodicalTrigger and fix '0' case error
| Q | A
| ------------- | ---
| Branch? | 6.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
While taking a peek at the code I found the possibility for this case slipping by the error checking.
To prevent code duplication I took the liberty to also merge the two checks since they are so similar.
Please let me know if there is any feedback on my pull request or if there are any questions.
Commits
-------
14f827b Add test for 0 and '0' in PeriodicalTrigger Fix '0' case error and remove duplicate codeFile tree
2 files changed
+4
-9
lines changed- src/Symfony/Component/Scheduler
- Tests/Trigger
- Trigger
2 files changed
+4
-9
lines changedLines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| 76 | + | |
| 77 | + | |
76 | 78 | | |
77 | 79 | | |
78 | 80 | | |
| |||
Lines changed: 2 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | | - | |
| 33 | + | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | 38 | | |
46 | 39 | | |
47 | 40 | | |
| |||
0 commit comments