bug symfony#58142 [HttpClient] fix supported amphp/http-client version detection (xabbuh)

xabbuh · xabbuh · commit 84f4837c8b16 · 2024-09-03T10:14:20.000+02:00
This PR was merged into the 7.2 branch. Discussion ---------- [HttpClient] fix supported `amphp/http-client` version detection | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- f72d8d7 fix supported amphp/http-client version detection
diff --git a/src/Symfony/Component/HttpClient/HttpClient.php b/src/Symfony/Component/HttpClient/HttpClient.php
@@ -31,7 +31,7 @@ final class HttpClient
      */
     public static function create(array $defaultOptions = [], int $maxHostConnections = 6, int $maxPendingPushes = 50): HttpClientInterface
     {
-        if ($amp = class_exists(AmpRequest::class) && (\PHP_VERSION_ID >= 80400 || is_subclass_of(AmpRequest::class, HttpMessage::class))) {
+        if ($amp = class_exists(AmpRequest::class) && (\PHP_VERSION_ID >= 80400 || !is_subclass_of(AmpRequest::class, HttpMessage::class))) {
             if (!\extension_loaded('curl')) {
                 return new AmpHttpClient($defaultOptions, null, $maxHostConnections, $maxPendingPushes);
             }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ final class HttpClient`
`31`	`31`	`*/`
`32`	`32`	`public static function create(array $defaultOptions = [], int $maxHostConnections = 6, int $maxPendingPushes = 50): HttpClientInterface`
`33`	`33`	`{`
`34`		`- if ($amp = class_exists(AmpRequest::class) && (\PHP_VERSION_ID >= 80400 \|\| is_subclass_of(AmpRequest::class, HttpMessage::class))) {`
	`34`	`+ if ($amp = class_exists(AmpRequest::class) && (\PHP_VERSION_ID >= 80400 \|\| !is_subclass_of(AmpRequest::class, HttpMessage::class))) {`
`35`	`35`	`if (!\extension_loaded('curl')) {`
`36`	`36`	`return new AmpHttpClient($defaultOptions, null, $maxHostConnections, $maxPendingPushes);`
`37`	`37`	`}`