bug symfony#61607 [Config] Fix ReflectionClassResource hash validation (HypeMC)

This PR was merged into the 7.3 branch.

Discussion
----------

[Config] Fix `ReflectionClassResource` hash validation

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

It looks like symfony#57948 broke hash validation.

The problem is that `$excludedVendors` is now used to generate the hash but is not serialized. After unserialization, the property is empty, so the generated hash never matches the dumped one.

Commits
-------

cec2f00 [Config] Fix `ReflectionClassResource` hash validation

Author: nicolas-grekas

src/Symfony/Component/Config/Resource/ReflectionClassResource.php

@@ -69,7 +69,7 @@ public function __sleep(): array
             $this->loadFiles($this->classReflector);
         }
 
-        return ['files', 'className', 'hash'];
+        return ['files', 'className', 'excludedVendors', 'hash'];
     }
 
     private function loadFiles(\ReflectionClass $class): void

src/Symfony/Component/Config/Tests/Fixtures/FakeVendor/Base.php

@@ -0,0 +1,27 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Config\Tests\Fixtures\FakeVendor;
+
+abstract class Base
+{
+    public $baseFoo;
+
+    protected $baseBar;
+
+    public function baseBaz()
+    {
+    }
+
+    public function baseQux()
+    {
+    }
+}

src/Symfony/Component/Config/Tests/Resource/ReflectionClassResourceTest.php

@@ -13,6 +13,7 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Config\Resource\ReflectionClassResource;
+use Symfony\Component\Config\Tests\Fixtures\FakeVendor\Base;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Contracts\Service\ServiceSubscriberInterface;
 
@@ -71,7 +72,7 @@ public function testHashedSignature(bool $changeExpected, int $changedLine, ?str
 
         $code = <<<'EOPHP'
 /* 0*/
-/* 1*/  class %s extends ErrorException
+/* 1*/  class %s extends %s
 /* 2*/  {
 /* 3*/      const FOO = 123;
 /* 4*/
@@ -91,22 +92,27 @@ public function testHashedSignature(bool $changeExpected, int $changedLine, ?str
 /*18*/  }
 EOPHP;
 
-        static $expectedSignature, $generateSignature;
+        static $expectedSignature, $signatureGenerator;
 
         if (null === $expectedSignature) {
-            eval(\sprintf($code, $class = 'Foo'.(string) $resourceClassNameSuffix));
+            eval(\sprintf($code, $class = 'Foo'.(string) $resourceClassNameSuffix, Base::class));
+
             $r = new \ReflectionClass(ReflectionClassResource::class);
             $generateSignature = $r->getMethod('generateSignature');
-            $generateSignature = $generateSignature->getClosure($r->newInstanceWithoutConstructor());
-            $expectedSignature = implode("\n", iterator_to_array($generateSignature(new \ReflectionClass($class))));
+
+            $res = new ReflectionClassResource(new \ReflectionClass($class), [\dirname(__DIR__).'/Fixtures/FakeVendor']);
+            $signatureGenerator = $generateSignature->getClosure($res);
+            $expectedSignature = implode("\n", iterator_to_array($signatureGenerator(new \ReflectionClass($class))));
+
+            $signatureGenerator = $generateSignature->getClosure(unserialize(serialize($res)));
         }
 
         $code = explode("\n", $code);
         if (null !== $changedCode) {
             $code[$changedLine] = $changedCode;
         }
-        eval(\sprintf(implode("\n", $code), $class = 'Bar'.(string) $resourceClassNameSuffix));
-        $signature = implode("\n", iterator_to_array($generateSignature(new \ReflectionClass($class))));
+        eval(\sprintf(implode("\n", $code), $class = 'Bar'.(string) $resourceClassNameSuffix, Base::class));
+        $signature = implode("\n", iterator_to_array($signatureGenerator(new \ReflectionClass($class))));
 
         if ($changeExpected) {
             $this->assertNotSame($expectedSignature, $signature);