Commit 8b82019
committed
This PR was merged into the 5.4 branch.
Discussion
----------
[Routing] Fix `testMissingPrefixLocale` and `testMissingRouteLocale`
| Q | A
| ------------- | ---
| Branch? | 5.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | symfony#51082 (comment)
| License | MIT
| Doc PR | not needed
Those two fixtures only exist as annotation versions. Their attribute counterparts were missing.
The corresponding tests only expected a `LogicException` which is what `AnnotationClassLoader` would raise for undefined classes as well.
This PR adds new assertions for the exception messages which would have discovered the missing fixtures. Finally, the two missing fixtures are added.
Commits
-------
6ba9864 [Routing] Fix testMissingPrefixLocale and testMissingRouteLocale
File tree
3 files changed
+30
-0
lines changed- src/Symfony/Component/Routing/Tests
- Fixtures/AttributeFixtures
- Loader
3 files changed
+30
-0
lines changedLines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
| 200 | + | |
200 | 201 | | |
201 | 202 | | |
202 | 203 | | |
203 | 204 | | |
204 | 205 | | |
205 | 206 | | |
| 207 | + | |
206 | 208 | | |
207 | 209 | | |
208 | 210 | | |
| |||
0 commit comments