[Tests] Streamline

Author: OskarStark

src/Symfony/Bridge/Doctrine/Tests/DependencyInjection/DoctrineExtensionTest.php

@@ -197,7 +197,7 @@ public function testMappingTypeDetection()
         $this->assertSame($mappingType, \PHP_VERSION_ID < 80000 ? 'annotation' : 'attribute');
     }
 
-    public static function providerBasicDrivers()
+    public static function providerBasicDrivers(): array
     {
         return [
             ['doctrine.orm.cache.apc.class',       ['type' => 'apc']],
@@ -276,7 +276,7 @@ public function testUnrecognizedCacheDriverException()
         $this->invokeLoadCacheDriver($objectManager, $container, $cacheName);
     }
 
-    public static function providerBundles()
+    public static function providerBundles(): iterable
     {
         yield ['AnnotationsBundle', \PHP_VERSION_ID < 80000 ? 'annotation' : 'attribute', '/Entity'];
         yield ['AnnotationsOneLineBundle', \PHP_VERSION_ID < 80000 ? 'annotation' : 'attribute', '/Entity'];

src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php

@@ -158,7 +158,7 @@ public function testChoiceTranslationDomainIsDisabledByDefault($expanded)
         }
     }
 
-    public static function choiceTranslationDomainProvider()
+    public static function choiceTranslationDomainProvider(): array
     {
         return [
             [false],
@@ -240,8 +240,6 @@ public function testConfigureQueryBuilderWithClosureReturningNonQueryBuilder()
                 return new \stdClass();
             },
         ]);
-
-        $field->submit('2');
     }
 
     public function testConfigureQueryBuilderWithClosureReturningNullUseDefault()

src/Symfony/Bridge/Doctrine/Tests/Validator/Constraints/UniqueEntityValidatorTest.php

@@ -479,7 +479,7 @@ public function testValidateResultTypes($entity1, $result)
         $this->assertNoViolation();
     }
 
-    public static function resultTypesProvider()
+    public static function resultTypesProvider(): array
     {
         $entity = new SingleIntIdEntity(1, 'foo');
 

src/Symfony/Bridge/Monolog/Tests/Handler/ConsoleHandlerTest.php

@@ -89,7 +89,7 @@ public function testVerbosityMapping($verbosity, $level, $isHandling, array $map
         $this->assertFalse($handler->handle($infoRecord), 'The handler finished handling the log.');
     }
 
-    public static function provideVerbosityMappingTests()
+    public static function provideVerbosityMappingTests(): array
     {
         return [
             [OutputInterface::VERBOSITY_QUIET, Logger::ERROR, true],

src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/ConfigurationTest.php

@@ -249,8 +249,8 @@ public function testToleratesForIndividualGroups(string $deprecationsHelper, arr
         }
     }
 
-    public static function provideDataForToleratesForGroup() {
-
+    public static function provideDataForToleratesForGroup(): iterable
+    {
         yield 'total threshold not reached' => ['max[total]=1', [
             'unsilenced' => 0,
             'self' => 0,

src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationTest.php

@@ -97,7 +97,7 @@ public function testItMutesOnlySpecificErrorMessagesWhenTheCallingCodeIsInPhpuni
         $this->assertSame($muted, $deprecation->isMuted());
     }
 
-    public static function mutedProvider()
+    public static function mutedProvider(): iterable
     {
         yield 'not from phpunit, and not a whitelisted message' => [
             false,
@@ -147,7 +147,7 @@ public function testItTakesMutesDeprecationFromPhpUnitFiles()
         $this->assertTrue($deprecation->isMuted());
     }
 
-    public static function providerGetTypeDetectsSelf()
+    public static function providerGetTypeDetectsSelf(): array
     {
         return [
             'not_from_vendors_file' => [Deprecation::TYPE_SELF, '', 'MyClass1', __FILE__],
@@ -182,7 +182,7 @@ public function testGetTypeDetectsSelf(string $expectedType, string $message, st
         $this->assertSame($expectedType, $deprecation->getType());
     }
 
-    public static function providerGetTypeUsesRightTrace()
+    public static function providerGetTypeUsesRightTrace(): array
     {
         $vendorDir = self::getVendorDir();
         $fakeTrace = [

src/Symfony/Bridge/Twig/Tests/AppVariableTest.php

@@ -43,7 +43,7 @@ public function testDebug($debugFlag)
         $this->assertEquals($debugFlag, $this->appVariable->getDebug());
     }
 
-    public static function debugDataProvider()
+    public static function debugDataProvider(): array
     {
         return [
             'debug on' => [true],

src/Symfony/Bridge/Twig/Tests/Command/LintCommandTest.php

@@ -150,7 +150,7 @@ public function testComplete(array $input, array $expectedSuggestions)
         $this->assertSame($expectedSuggestions, $tester->complete($input));
     }
 
-    public static function provideCompletionSuggestions()
+    public static function provideCompletionSuggestions(): iterable
     {
         yield 'option' => [['--format', ''], ['txt', 'json', 'github']];
     }

src/Symfony/Bridge/Twig/Tests/Extension/FormExtensionDivLayoutTest.php

@@ -100,7 +100,7 @@ public function testThemeBlockInheritanceUsingDynamicExtend()
         );
     }
 
-    public static function isSelectedChoiceProvider()
+    public static function isSelectedChoiceProvider(): array
     {
         return [
             [true, '0', '0'],
@@ -150,7 +150,7 @@ public function testStartTagHasActionAttributeWhenActionIsZero()
         $this->assertSame('<form name="form" method="get" action="0">', $html);
     }
 
-    public static function isRootFormProvider()
+    public static function isRootFormProvider(): array
     {
         return [
             [true, new FormView()],
@@ -381,14 +381,14 @@ protected function setTheme(FormView $view, array $themes, $useDefaultThemes = t
         $this->renderer->setTheme($view, $themes, $useDefaultThemes);
     }
 
-    public static function themeBlockInheritanceProvider()
+    public static function themeBlockInheritanceProvider(): array
     {
         return [
             [['theme.html.twig']],
         ];
     }
 
-    public static function themeInheritanceProvider()
+    public static function themeInheritanceProvider(): array
     {
         return [
             [['parent_label.html.twig'], ['child_label.html.twig']],

src/Symfony/Bundle/FrameworkBundle/Tests/CacheWarmer/SerializerCacheWarmerTest.php

@@ -40,7 +40,7 @@ public function testWarmUp(array $loaders)
         $this->assertTrue($arrayPool->getItem('Symfony_Bundle_FrameworkBundle_Tests_Fixtures_Serialization_Author')->isHit());
     }
 
-    public static function loaderProvider()
+    public static function loaderProvider(): array
     {
         return [
             [