bug symfony#59731 [Scheduler] make newly added constructor argument optional (xabbuh)

This PR was merged into the 7.3 branch.

Discussion
----------

[Scheduler] make newly added constructor argument optional

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

As the PostRunEvent class is already present in Symfony since 6.4 we cannot add new mandatory constructor arguments without breaking backwards compatibility.

Commits
-------

6716e88 make newly added constructor argument optional

Author: fabpot

src/Symfony/Component/Scheduler/Event/PostRunEvent.php

@@ -20,7 +20,7 @@ public function __construct(
         private readonly ScheduleProviderInterface $schedule,
         private readonly MessageContext $messageContext,
         private readonly object $message,
-        private readonly mixed $result,
+        private readonly mixed $result = null,
     ) {
     }
 

src/Symfony/Component/Scheduler/Tests/EventListener/DispatchSchedulerEventListenerTest.php

@@ -57,8 +57,8 @@ public function testDispatchSchedulerEvents()
         $listener->onMessageFailed($workerFailedEvent);
 
         $this->assertInstanceOf(PreRunEvent::class, $secondListener->preRunEvent);
-        $this->assertSame('result', $secondListener->postRunEvent->getResult());
         $this->assertInstanceOf(PostRunEvent::class, $secondListener->postRunEvent);
+        $this->assertSame('result', $secondListener->postRunEvent->getResult());
         $this->assertInstanceOf(FailureEvent::class, $secondListener->failureEvent);
         $this->assertEquals(new \Exception('failed'), $secondListener->failureEvent->getError());
     }