bug symfony#58525 [Notifier] silence warnings triggered when malformed XML is parsed (xabbuh)

xabbuh · xabbuh · commit a2991ca69cfa · 2024-10-17T08:22:26.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [Notifier] silence warnings triggered when malformed XML is parsed | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT The constructor of the `SimpleXMLElement` class issues a warning if the passed data is not valid. Commits ------- aa3c91b silence warnings triggered when malformed XML is parsed
diff --git a/src/Symfony/Component/Notifier/Bridge/KazInfoTeh/KazInfoTehTransport.php b/src/Symfony/Component/Notifier/Bridge/KazInfoTeh/KazInfoTehTransport.php
@@ -80,7 +80,7 @@ protected function doSend(MessageInterface $message): SentMessage
         }
 
         try {
-            $content = new \SimpleXMLElement($response->getContent(false));
+            $content = @new \SimpleXMLElement($response->getContent(false));
         } catch (\Exception $e) {
             throw new TransportException('Unable to send the SMS: "Couldn\'t read response".', $response, previous: $e);
         }

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ protected function doSend(MessageInterface $message): SentMessage`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`try {`
`83`		`- $content = new \SimpleXMLElement($response->getContent(false));`
	`83`	`+ $content = @new \SimpleXMLElement($response->getContent(false));`
`84`	`84`	`} catch (\Exception $e) {`
`85`	`85`	`throw new TransportException('Unable to send the SMS: "Couldn\'t read response".', $response, previous: $e);`
`86`	`86`	`}`