Commit a92dd0d
committed
bug symfony#52579 [DomCrawler] UriResolver support path with colons (vdauchy)
This PR was merged into the 5.4 branch.
Discussion
----------
[DomCrawler] UriResolver support path with colons
| Q | A
| ------------- | ---
| Branch? | 5.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Issues | Fix UriResolver bad handling of column in path
| License | MIT
Resolving links on pages using weird pagination like: ```https://localhost/domain/search/page:5``` fails due to `:` making
```
var_dump(parse_url('/page:1', \PHP_URL_SCHEME));
```
Return `false` (and not null as expected in the code).
This simply ensure the absolute URL is returned only if the SCHEME is found (ie a string is returned by `parse_url`).
Commits
-------
89009aa [DomCrawler] UriResolver support path with columnsFile tree
2 files changed
+5
-1
lines changed- src/Symfony/Component/DomCrawler
- Tests
2 files changed
+5
-1
lines changedLines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
87 | 91 | | |
88 | 92 | | |
89 | 93 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
0 commit comments