minor symfony#59898 replace assertEmpty() with stricter assertions (xabbuh)

This PR was merged into the 7.3 branch.

Discussion
----------

replace `assertEmpty()` with stricter assertions

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

In the code we are strict about not using `empty()`. In my opinion it makes sense to be equally strict with our assertions. But I'd like to gather some feedback first before updating all places.

Commits
-------

6550cb8 replace assertEmpty() with stricter assertions

Author: fabpot

src/Symfony/Bridge/Doctrine/Tests/Validator/DoctrineLoaderTest.php

@@ -210,7 +210,7 @@ public function testClassNoAutoMapping()
         $this->assertSame(AutoMappingStrategy::DISABLED, $classMetadata->getAutoMappingStrategy());
 
         $maxLengthMetadata = $classMetadata->getPropertyMetadata('maxLength');
-        $this->assertEmpty($maxLengthMetadata);
+        $this->assertSame([], $maxLengthMetadata);
 
         /** @var PropertyMetadata[] $autoMappingExplicitlyEnabledMetadata */
         $autoMappingExplicitlyEnabledMetadata = $classMetadata->getPropertyMetadata('autoMappingExplicitlyEnabled');

src/Symfony/Bridge/PhpUnit/Tests/Metadata/AttributeReaderTest.php

@@ -71,7 +71,7 @@ public function testAttributesAreCached()
         $reader = new AttributeReader();
         $cacheRef = new \ReflectionProperty(AttributeReader::class, 'cache');
 
-        self::assertEmpty($cacheRef->getValue($reader));
+        self::assertSame([], $cacheRef->getValue($reader));
 
         $reader->forClass(FooBar::class, TimeSensitive::class);
 

src/Symfony/Bridge/Twig/Tests/Extension/AbstractLayoutTestCase.php

@@ -1592,7 +1592,7 @@ public function testDateErrorBubbling()
         $form->get('date')->addError(new FormError('[trans]Error![/trans]'));
         $view = $form->createView();
 
-        $this->assertEmpty($this->renderErrors($view));
+        $this->assertSame('', $this->renderErrors($view));
         $this->assertNotEmpty($this->renderErrors($view['date']));
     }
 
@@ -2213,7 +2213,7 @@ public function testTimeErrorBubbling()
         $form->get('time')->addError(new FormError('[trans]Error![/trans]'));
         $view = $form->createView();
 
-        $this->assertEmpty($this->renderErrors($view));
+        $this->assertSame('', $this->renderErrors($view));
         $this->assertNotEmpty($this->renderErrors($view['time']));
     }
 

src/Symfony/Bridge/Twig/Tests/Extension/DumpExtensionTest.php

@@ -142,6 +142,6 @@ public function testCustomDumper()
             'Custom dumper should be used to dump data.'
         );
 
-        $this->assertEmpty($output, 'Dumper output should be ignored.');
+        $this->assertSame('', $output, 'Dumper output should be ignored.');
     }
 }

src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTestCase.php

@@ -796,7 +796,7 @@ public function testMessengerServicesRemovedWhenDisabled()
             \ARRAY_FILTER_USE_KEY
         );
 
-        $this->assertEmpty($messengerDefinitions);
+        $this->assertSame([], $messengerDefinitions);
         $this->assertFalse($container->hasDefinition('console.command.messenger_consume_messages'));
         $this->assertFalse($container->hasDefinition('console.command.messenger_debug'));
         $this->assertFalse($container->hasDefinition('console.command.messenger_stop_workers'));
@@ -1941,7 +1941,7 @@ public function testRemovesResourceCheckerConfigCacheFactoryArgumentOnlyIfNoDebu
 
         $container = $this->createContainer(['kernel.debug' => false]);
         (new FrameworkExtension())->load([['annotations' => false, 'http_method_override' => false, 'handle_all_throwables' => true, 'php_errors' => ['log' => true]]], $container);
-        $this->assertEmpty($container->getDefinition('config_cache_factory')->getArguments());
+        $this->assertSame([], $container->getDefinition('config_cache_factory')->getArguments());
     }
 
     public function testLoggerAwareRegistration()

src/Symfony/Bundle/FrameworkBundle/Tests/Functional/ApiAttributesTest.php

@@ -34,7 +34,7 @@ public function testMapQueryString(string $uri, array $query, string $expectedRe
         if ($expectedResponse) {
             self::assertJsonStringEqualsJsonString($expectedResponse, $response->getContent());
         } else {
-            self::assertEmpty($response->getContent());
+            self::assertSame('', $response->getContent());
         }
         self::assertSame($expectedStatusCode, $response->getStatusCode());
     }

src/Symfony/Bundle/SecurityBundle/Tests/DataCollector/SecurityDataCollectorTest.php

@@ -54,7 +54,7 @@ public function testCollectWhenSecurityIsDisabled()
         $this->assertFalse($collector->supportsRoleHierarchy());
         $this->assertCount(0, $collector->getRoles());
         $this->assertCount(0, $collector->getInheritedRoles());
-        $this->assertEmpty($collector->getUser());
+        $this->assertSame('', $collector->getUser());
         $this->assertNull($collector->getFirewall());
     }
 
@@ -73,7 +73,7 @@ public function testCollectWhenAuthenticationTokenIsNull()
         $this->assertTrue($collector->supportsRoleHierarchy());
         $this->assertCount(0, $collector->getRoles());
         $this->assertCount(0, $collector->getInheritedRoles());
-        $this->assertEmpty($collector->getUser());
+        $this->assertSame('', $collector->getUser());
         $this->assertNull($collector->getFirewall());
     }
 
@@ -425,7 +425,7 @@ public function testGetVotersIfAccessDecisionManagerHasNoVoters()
 
         $dataCollector->collect(new Request(), new Response());
 
-        $this->assertEmpty($dataCollector->getVoters());
+        $this->assertSame([], $dataCollector->getVoters());
     }
 
     public static function provideRoles(): array

src/Symfony/Component/Asset/Tests/Context/NullContextTest.php

@@ -20,7 +20,7 @@ public function testGetBasePath()
     {
         $nullContext = new NullContext();
 
-        $this->assertEmpty($nullContext->getBasePath());
+        $this->assertSame('', $nullContext->getBasePath());
     }
 
     public function testIsSecure()

src/Symfony/Component/Asset/Tests/Context/RequestStackContextTest.php

@@ -22,7 +22,7 @@ public function testGetBasePathEmpty()
     {
         $requestStackContext = new RequestStackContext(new RequestStack());
 
-        $this->assertEmpty($requestStackContext->getBasePath());
+        $this->assertSame('', $requestStackContext->getBasePath());
     }
 
     public function testGetBasePathSet()

src/Symfony/Component/Asset/Tests/VersionStrategy/EmptyVersionStrategyTest.php

@@ -21,7 +21,7 @@ public function testGetVersion()
         $emptyVersionStrategy = new EmptyVersionStrategy();
         $path = 'test-path';
 
-        $this->assertEmpty($emptyVersionStrategy->getVersion($path));
+        $this->assertSame('', $emptyVersionStrategy->getVersion($path));
     }
 
     public function testApplyVersion()