Merge branch '5.4' into 6.3

* 5.4:
  [5.4] Remove unused test fixtures
  [Dotent] Add PHPDoc for `$overrideExistingVars`
  [SecurityBundle] Fix missing login-link element in xsd schema
  [Validator] Add missing Chinese translations symfony#51934
  [Serializer] Fix using `DateIntervalNormalizer` with union types
  [Validator] fix: add missing translations for for Thai (th)
  fix symfony#52273 [doctrine-messenger] DB table locks on messenger_messages with many failures
  [Serializer] Handle defaultContext for DateTimeNormalizer
  [CI] Add step to verify symfony/deprecation-contracts requirements

Author: fabpot

.github/get-modified-packages.php

@@ -66,8 +66,10 @@ function getPackageType(string $packageDir): string
 
 $output = [];
 foreach ($modifiedPackages as $directory => $bool) {
-    $name = json_decode(file_get_contents($directory.'/composer.json'), true)['name'] ?? 'unknown';
-    $output[] = ['name' => $name, 'directory' => $directory, 'new' => $newPackage[$directory] ?? false, 'type' => getPackageType($directory)];
+    $composerData = json_decode(file_get_contents($directory.'/composer.json'), true);
+    $name = $composerData['name'] ?? 'unknown';
+    $requiresDeprecationContracts = isset($composerData['require']['symfony/deprecation-contracts']);
+    $output[] = ['name' => $name, 'directory' => $directory, 'new' => $newPackage[$directory] ?? false, 'type' => getPackageType($directory), 'requires_deprecation_contracts' => $requiresDeprecationContracts];
 }
 
 echo json_encode($output);

.github/workflows/package-tests.yml

@@ -100,4 +100,44 @@ jobs:
               fi
           done
 
+          exit $ok
+      - name: Verify symfony/deprecation-contracts requirements
+        run: |
+          set +e
+
+          ok=0
+          json='${{ steps.find-packages.outputs.packages }}'
+          for package in $(echo "${json}" | jq -r '.[] | @base64'); do
+              _jq() {
+                echo ${package} | base64 --decode | jq -r ${1}
+              }
+
+              NAME=$(_jq '.name')
+              if [[ $NAME = 'symfony/deprecation-contracts' || $NAME = 'symfony/contracts' ]]; then
+                continue
+              fi
+
+              echo "::group::$NAME"
+              DIR=$(_jq '.directory')
+              localExit=0
+              grep -rq 'trigger_deprecation(' --include=*.php --exclude-dir=Tests/ --exclude-dir=Bridge/ $DIR
+              triggersDeprecation=$?
+              if [[ $triggersDeprecation -eq 0 && $(_jq '.requires_deprecation_contracts') == false ]]; then
+                errorMessage="::error::$NAME does not require symfony/deprecation-contracts but triggers at least one deprecation"
+                localExit=1
+              elif [[ $triggersDeprecation -eq 1 && $(_jq '.requires_deprecation_contracts') == true ]]; then
+                errorMessage="::error::$NAME requires symfony/deprecation-contracts but does not trigger any deprecation"
+                localExit=1
+              elif [[ $triggersDeprecation -ne 0 && $triggersDeprecation -ne 1 ]]; then
+                echo "::error::grep failed"
+                exit 2
+              fi
+
+              ok=$(( $localExit || $ok ))
+              echo ::endgroup::
+              if [ $localExit -ne 0 ]; then
+                echo $errorMessage
+              fi
+          done
+
           exit $ok