[Cache] Remove temporary cache item file on rename() failure

Author: cedric-anne

src/Symfony/Component/Cache/Traits/FilesystemCommonTrait.php

@@ -90,6 +90,7 @@ protected function doUnlink(string $file)
 
     private function write(string $file, string $data, int $expiresAt = null)
     {
+        $unlink = false;
         set_error_handler(__CLASS__.'::throwError');
         try {
             if (null === $this->tmp) {
@@ -107,14 +108,22 @@ private function write(string $file, string $data, int $expiresAt = null)
             }
             fwrite($h, $data);
             fclose($h);
+            $unlink = true;
 
             if (null !== $expiresAt) {
                 touch($this->tmp, $expiresAt ?: time() + 31556952); // 1 year in seconds
             }
 
-            return rename($this->tmp, $file);
+            $success = rename($this->tmp, $file);
+            $unlink = !$success;
+
+            return $success;
         } finally {
             restore_error_handler();
+
+            if ($unlink) {
+                @unlink($this->tmp);
+            }
         }
     }