Merge branch '6.4' into 7.3

nicolas-grekas · nicolas-grekas · commit b851d21e4e99 · 2025-08-13T13:49:31.000+02:00
* 6.4:
  Remove calls to no-op functions, deprecated in PHP 8.5
  Remove deprecated calls to deprecated methods of SplObjectStorage
  [Messenger] Show package installation hint also for amqps
diff --git a/src/Symfony/Bridge/Monolog/Handler/ElasticsearchLogstashHandler.php b/src/Symfony/Bridge/Monolog/Handler/ElasticsearchLogstashHandler.php
@@ -133,7 +133,7 @@ private function sendToElasticsearch(array $records): void
             ],
         ]);
 
-        $this->responses->attach($response);
+        $this->responses[$response] = null;
 
         $this->wait(false);
     }
@@ -164,10 +164,10 @@ private function wait(bool $blocking): void
                     continue;
                 }
                 if ($chunk->isLast()) {
-                    $this->responses->detach($response);
+                    unset($this->responses[$response]);
                 }
             } catch (ExceptionInterface $e) {
-                $this->responses->detach($response);
+                unset($this->responses[$response]);
                 error_log(\sprintf("Could not push logs to Elasticsearch:\n%s", (string) $e));
             }
         }
diff --git a/src/Symfony/Bridge/Twig/Tests/Extension/WorkflowExtensionTest.php b/src/Symfony/Bridge/Twig/Tests/Extension/WorkflowExtensionTest.php
@@ -36,7 +36,7 @@ protected function setUp(): void
         ];
 
         $transitionsMetadata = new \SplObjectStorage();
-        $transitionsMetadata->attach($this->t1, ['title' => 't1 title']);
+        $transitionsMetadata[$this->t1] = ['title' => 't1 title'];
         $metadataStore = new InMemoryMetadataStore(
             ['title' => 'workflow title'],
             ['orderer' => ['title' => 'ordered title']],
diff --git a/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php b/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
@@ -799,7 +799,7 @@ private function addServiceConfigurator(Definition $definition, string $variable
 
         if (\is_array($callable)) {
             if ($callable[0] instanceof Reference
-                || ($callable[0] instanceof Definition && $this->definitionVariables->contains($callable[0]))
+                || ($callable[0] instanceof Definition && $this->definitionVariables->offsetExists($callable[0]))
             ) {
                 return \sprintf("        %s->%s(\$%s);\n", $this->dumpValue($callable[0]), $callable[1], $variableName);
             }
@@ -1187,15 +1187,15 @@ private function addNewInstance(Definition $definition, string $return = '', ?st
 
             if (['...'] === $arguments && ('Closure' !== ($class = $definition->getClass() ?: 'Closure') || $definition->isLazy() && (
                 $callable[0] instanceof Reference
-                || ($callable[0] instanceof Definition && !$this->definitionVariables->contains($callable[0]))
+                || ($callable[0] instanceof Definition && !$this->definitionVariables->offsetExists($callable[0]))
             ))) {
                 $initializer = 'fn () => '.$this->dumpValue($callable[0]);
 
                 return $return.LazyClosure::getCode($initializer, $callable, $class, $this->container, $id).$tail;
             }
 
             if ($callable[0] instanceof Reference
-                || ($callable[0] instanceof Definition && $this->definitionVariables->contains($callable[0]))
+                || ($callable[0] instanceof Definition && $this->definitionVariables->offsetExists($callable[0]))
             ) {
                 return $return.\sprintf('%s->%s(%s)', $this->dumpValue($callable[0]), $callable[1], $arguments ? implode(', ', $arguments) : '').$tail;
             }
@@ -1937,7 +1937,7 @@ private function dumpValue(mixed $value, bool $interpolate = true): string
             if ($value->hasErrors() && $e = $value->getErrors()) {
                 return \sprintf('throw new RuntimeException(%s)', $this->export(reset($e)));
             }
-            if ($this->definitionVariables?->contains($value)) {
+            if ($this->definitionVariables?->offsetExists($value)) {
                 return $this->dumpValue($this->definitionVariables[$value], $interpolate);
             }
             if ($value->getMethodCalls()) {
diff --git a/src/Symfony/Component/EventDispatcher/Debug/TraceableEventDispatcher.php b/src/Symfony/Component/EventDispatcher/Debug/TraceableEventDispatcher.php
@@ -259,7 +259,7 @@ private function preProcess(string $eventName): void
             $this->wrappedListeners[$eventName][] = $wrappedListener;
             $this->dispatcher->removeListener($eventName, $listener);
             $this->dispatcher->addListener($eventName, $wrappedListener, $priority);
-            $this->callStack->attach($wrappedListener, [$eventName, $this->currentRequestHash]);
+            $this->callStack[$wrappedListener] = [$eventName, $this->currentRequestHash];
         }
     }
 
@@ -283,7 +283,7 @@ private function postProcess(string $eventName): void
             if ($listener->wasCalled()) {
                 $this->logger?->debug('Notified event "{event}" to listener "{listener}".', $context);
             } else {
-                $this->callStack->detach($listener);
+                unset($this->callStack[$listener]);
             }
 
             if (null !== $this->logger && $skipped) {
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformerTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformerTest.php
@@ -35,7 +35,6 @@ protected function setUp(): void
         // Normalize intl. configuration settings.
         if (\extension_loaded('intl')) {
             $this->initialTestCaseUseException = ini_set('intl.use_exceptions', 0);
-            $this->initialTestCaseErrorLevel = ini_set('intl.error_level', 0);
         }
 
         // Since we test against "de_AT", we need the full implementation
@@ -54,7 +53,6 @@ protected function tearDown(): void
 
         if (\extension_loaded('intl')) {
             ini_set('intl.use_exceptions', $this->initialTestCaseUseException);
-            ini_set('intl.error_level', $this->initialTestCaseErrorLevel);
         }
     }
 
@@ -345,6 +343,7 @@ public function testReverseTransformFiveDigitYearsWithTimestamp()
 
     /**
      * @requires extension intl
+     * @requires PHP < 8.5
      */
     public function testReverseTransformWrapsIntlErrorsWithErrorLevel()
     {
@@ -377,6 +376,7 @@ public function testReverseTransformWrapsIntlErrorsWithExceptions()
 
     /**
      * @requires extension intl
+     * @requires PHP < 8.5
      */
     public function testReverseTransformWrapsIntlErrorsWithExceptionsAndErrorLevel()
     {
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php
@@ -21,14 +21,12 @@ class NumberToLocalizedStringTransformerTest extends TestCase
     private string $defaultLocale;
 
     private $initialTestCaseUseException;
-    private $initialTestCaseErrorLevel;
 
     protected function setUp(): void
     {
         // Normalize intl. configuration settings.
         if (\extension_loaded('intl')) {
             $this->initialTestCaseUseException = ini_set('intl.use_exceptions', 0);
-            $this->initialTestCaseErrorLevel = ini_set('intl.error_level', 0);
         }
 
         $this->defaultLocale = \Locale::getDefault();
@@ -41,7 +39,6 @@ protected function tearDown(): void
 
         if (\extension_loaded('intl')) {
             ini_set('intl.use_exceptions', $this->initialTestCaseUseException);
-            ini_set('intl.error_level', $this->initialTestCaseErrorLevel);
         }
     }
 
@@ -664,6 +661,7 @@ public function testReverseTransformENotation($output, $input)
 
     /**
      * @requires extension intl
+     * @requires PHP < 8.5
      */
     public function testReverseTransformWrapsIntlErrorsWithErrorLevel()
     {
@@ -696,6 +694,7 @@ public function testReverseTransformWrapsIntlErrorsWithExceptions()
 
     /**
      * @requires extension intl
+     * @requires PHP < 8.5
      */
     public function testReverseTransformWrapsIntlErrorsWithExceptionsAndErrorLevel()
     {
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/PercentToLocalizedStringTransformerTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/PercentToLocalizedStringTransformerTest.php
@@ -21,14 +21,12 @@ class PercentToLocalizedStringTransformerTest extends TestCase
     private string $defaultLocale;
 
     private $initialTestCaseUseException;
-    private $initialTestCaseErrorLevel;
 
     protected function setUp(): void
     {
         // Normalize intl. configuration settings.
         if (\extension_loaded('intl')) {
             $this->initialTestCaseUseException = ini_set('intl.use_exceptions', 0);
-            $this->initialTestCaseErrorLevel = ini_set('intl.error_level', 0);
         }
 
         $this->defaultLocale = \Locale::getDefault();
@@ -41,7 +39,6 @@ protected function tearDown(): void
 
         if (\extension_loaded('intl')) {
             ini_set('intl.use_exceptions', $this->initialTestCaseUseException);
-            ini_set('intl.error_level', $this->initialTestCaseErrorLevel);
         }
     }
 
@@ -492,6 +489,7 @@ public function testReverseTransformForHtml5FormatWithScale()
 
     /**
      * @requires extension intl
+     * @requires PHP < 8.5
      */
     public function testReverseTransformWrapsIntlErrorsWithErrorLevel()
     {
@@ -524,6 +522,7 @@ public function testReverseTransformWrapsIntlErrorsWithExceptions()
 
     /**
      * @requires extension intl
+     * @requires PHP < 8.5
      */
     public function testReverseTransformWrapsIntlErrorsWithExceptionsAndErrorLevel()
     {
diff --git a/src/Symfony/Component/HttpClient/Internal/CurlClientState.php b/src/Symfony/Component/HttpClient/Internal/CurlClientState.php
@@ -83,7 +83,6 @@ public function reset(): void
         foreach ($this->pushedResponses as $url => $response) {
             $this->logger?->debug(\sprintf('Unused pushed response: "%s"', $url));
             curl_multi_remove_handle($this->handle, $response->handle);
-            curl_close($response->handle);
         }
 
         $this->pushedResponses = [];
diff --git a/src/Symfony/Component/HttpKernel/DataCollector/RouterDataCollector.php b/src/Symfony/Component/HttpKernel/DataCollector/RouterDataCollector.php
@@ -40,7 +40,7 @@ public function collect(Request $request, Response $response, ?\Throwable $excep
             $this->data['redirect'] = true;
             $this->data['url'] = $response->getTargetUrl();
 
-            if ($this->controllers->contains($request)) {
+            if ($this->controllers->offsetExists($request)) {
                 $this->data['route'] = $this->guessRoute($request, $this->controllers[$request]);
             }
         }
diff --git a/src/Symfony/Component/Mailer/Transport/RoundRobinTransport.php b/src/Symfony/Component/Mailer/Transport/RoundRobinTransport.php
@@ -84,7 +84,7 @@ protected function getNextTransport(): ?TransportInterface
             }
 
             if ((microtime(true) - $this->deadTransports[$transport]) > $this->retryPeriod) {
-                $this->deadTransports->detach($transport);
+                unset($this->deadTransports[$transport]);
 
                 break;
             }
@@ -101,7 +101,7 @@ protected function getNextTransport(): ?TransportInterface
 
     protected function isTransportDead(TransportInterface $transport): bool
     {
-        return $this->deadTransports->contains($transport);
+        return $this->deadTransports->offsetExists($transport);
     }
 
     protected function getInitialCursor(): int
diff --git a/src/Symfony/Component/Messenger/Tests/WorkerTest.php b/src/Symfony/Component/Messenger/Tests/WorkerTest.php
@@ -621,7 +621,7 @@ public function dispatch(object $message, array $stamps = []): Envelope
         $unacks = $unacksProperty->getValue($worker);
         $dummyHandler = new DummyBatchHandler();
         $envelopeWithNoAutoAck = $envelope->with(new NoAutoAckStamp(new HandlerDescriptor($dummyHandler)));
-        $unacks->attach($dummyHandler, [$envelopeWithNoAutoAck, 'transport']);
+        $unacks[$dummyHandler] = [$envelopeWithNoAutoAck, 'transport'];
 
         $worker->run();
 
diff --git a/src/Symfony/Component/Messenger/Transport/TransportFactory.php b/src/Symfony/Component/Messenger/Transport/TransportFactory.php
@@ -39,7 +39,7 @@ public function createTransport(#[\SensitiveParameter] string $dsn, array $optio
 
         // Help the user to select Symfony packages based on protocol.
         $packageSuggestion = '';
-        if (str_starts_with($dsn, 'amqp://')) {
+        if (str_starts_with($dsn, 'amqp://') || str_starts_with($dsn, 'amqps://')) {
             $packageSuggestion = ' Run "composer require symfony/amqp-messenger" to install AMQP transport.';
         } elseif (str_starts_with($dsn, 'doctrine://')) {
             $packageSuggestion = ' Run "composer require symfony/doctrine-messenger" to install Doctrine transport.';
diff --git a/src/Symfony/Component/Notifier/Transport/RoundRobinTransport.php b/src/Symfony/Component/Notifier/Transport/RoundRobinTransport.php
@@ -103,7 +103,7 @@ protected function getNextTransport(MessageInterface $message): ?TransportInterf
             }
 
             if ((microtime(true) - $this->deadTransports[$transport]) > $this->retryPeriod) {
-                $this->deadTransports->detach($transport);
+                unset($this->deadTransports[$transport]);
 
                 break;
             }
@@ -120,7 +120,7 @@ protected function getNextTransport(MessageInterface $message): ?TransportInterf
 
     protected function isTransportDead(TransportInterface $transport): bool
     {
-        return $this->deadTransports->contains($transport);
+        return $this->deadTransports->offsetExists($transport);
     }
 
     protected function getInitialCursor(): int
diff --git a/src/Symfony/Component/Validator/Constraints/ImageValidator.php b/src/Symfony/Component/Validator/Constraints/ImageValidator.php
@@ -235,8 +235,6 @@ public function validate(mixed $value, Constraint $constraint): void
 
                 return;
             }
-
-            imagedestroy($resource);
         }
     }
 
diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/SplCasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/SplCasterTest.php
@@ -148,7 +148,7 @@ public static function provideCastSplDoublyLinkedList()
     public function testCastObjectStorageIsntModified()
     {
         $var = new \SplObjectStorage();
-        $var->attach(new \stdClass());
+        $var[new \stdClass()] = null;
         $var->rewind();
         $current = $var->current();
 
@@ -159,7 +159,7 @@ public function testCastObjectStorageIsntModified()
     public function testCastObjectStorageDumpsInfo()
     {
         $var = new \SplObjectStorage();
-        $var->attach(new \stdClass(), new \DateTimeImmutable());
+        $var[new \stdClass()] = new \DateTimeImmutable();
 
         $this->assertDumpMatchesFormat('%ADateTimeImmutable%A', $var);
     }
diff --git a/src/Symfony/Component/VarExporter/Internal/Hydrator.php b/src/Symfony/Component/VarExporter/Internal/Hydrator.php
@@ -80,7 +80,7 @@ public static function getHydrator($class)
                         if ("\0" === $name) {
                             foreach ($values as $i => $v) {
                                 for ($j = 0; $j < \count($v); ++$j) {
-                                    $objects[$i]->attach($v[$j], $v[++$j]);
+                                    $objects[$i][$v[$j]] = $v[++$j];
                                 }
                             }
                             continue;
@@ -188,7 +188,7 @@ public static function getSimpleHydrator($class)
                             continue;
                         }
                         for ($i = 0; $i < \count($value); ++$i) {
-                            $object->attach($value[$i], $value[++$i]);
+                            $object[$value[$i]] = $value[++$i];
                         }
                     }
                 };

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ private function sendToElasticsearch(array $records): void`
`133`	`133`	`],`
`134`	`134`	`]);`
`135`	`135`
`136`		`- $this->responses->attach($response);`
	`136`	`+ $this->responses[$response] = null;`
`137`	`137`
`138`	`138`	`$this->wait(false);`
`139`	`139`	`}`
`@@ -164,10 +164,10 @@ private function wait(bool $blocking): void`
`164`	`164`	`continue;`
`165`	`165`	`}`
`166`	`166`	`if ($chunk->isLast()) {`
`167`		`- $this->responses->detach($response);`
	`167`	`+ unset($this->responses[$response]);`
`168`	`168`	`}`
`169`	`169`	`} catch (ExceptionInterface $e) {`
`170`		`- $this->responses->detach($response);`
	`170`	`+ unset($this->responses[$response]);`
`171`	`171`	`error_log(\sprintf("Could not push logs to Elasticsearch:\n%s", (string) $e));`
`172`	`172`	`}`
`173`	`173`	`}`
Original file line number	Diff line number	Diff line change
`@@ -259,7 +259,7 @@ private function preProcess(string $eventName): void`
`259`	`259`	`$this->wrappedListeners[$eventName][] = $wrappedListener;`
`260`	`260`	`$this->dispatcher->removeListener($eventName, $listener);`
`261`	`261`	`$this->dispatcher->addListener($eventName, $wrappedListener, $priority);`
`262`		`- $this->callStack->attach($wrappedListener, [$eventName, $this->currentRequestHash]);`
	`262`	`+ $this->callStack[$wrappedListener] = [$eventName, $this->currentRequestHash];`
`263`	`263`	`}`
`264`	`264`	`}`
`265`	`265`
`@@ -283,7 +283,7 @@ private function postProcess(string $eventName): void`
`283`	`283`	`if ($listener->wasCalled()) {`
`284`	`284`	`$this->logger?->debug('Notified event "{event}" to listener "{listener}".', $context);`
`285`	`285`	`} else {`
`286`		`- $this->callStack->detach($listener);`
	`286`	`+ unset($this->callStack[$listener]);`
`287`	`287`	`}`
`288`	`288`
`289`	`289`	`if (null !== $this->logger && $skipped) {`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,6 @@ protected function setUp(): void`
`35`	`35`	`// Normalize intl. configuration settings.`
`36`	`36`	`if (\extension_loaded('intl')) {`
`37`	`37`	`$this->initialTestCaseUseException = ini_set('intl.use_exceptions', 0);`
`38`		`- $this->initialTestCaseErrorLevel = ini_set('intl.error_level', 0);`
`39`	`38`	`}`
`40`	`39`
`41`	`40`	`// Since we test against "de_AT", we need the full implementation`
`@@ -54,7 +53,6 @@ protected function tearDown(): void`
`54`	`53`
`55`	`54`	`if (\extension_loaded('intl')) {`
`56`	`55`	`ini_set('intl.use_exceptions', $this->initialTestCaseUseException);`
`57`		`- ini_set('intl.error_level', $this->initialTestCaseErrorLevel);`
`58`	`56`	`}`
`59`	`57`	`}`
`60`	`58`
`@@ -345,6 +343,7 @@ public function testReverseTransformFiveDigitYearsWithTimestamp()`
`345`	`343`
`346`	`344`	`/**`
`347`	`345`	`* @requires extension intl`
	`346`	`+ * @requires PHP < 8.5`
`348`	`347`	`*/`
`349`	`348`	`public function testReverseTransformWrapsIntlErrorsWithErrorLevel()`
`350`	`349`	`{`
`@@ -377,6 +376,7 @@ public function testReverseTransformWrapsIntlErrorsWithExceptions()`
`377`	`376`
`378`	`377`	`/**`
`379`	`378`	`* @requires extension intl`
	`379`	`+ * @requires PHP < 8.5`
`380`	`380`	`*/`
`381`	`381`	`public function testReverseTransformWrapsIntlErrorsWithExceptionsAndErrorLevel()`
`382`	`382`	`{`
Original file line number	Diff line number	Diff line change
`@@ -21,14 +21,12 @@ class NumberToLocalizedStringTransformerTest extends TestCase`
`21`	`21`	`private string $defaultLocale;`
`22`	`22`
`23`	`23`	`private $initialTestCaseUseException;`
`24`		`- private $initialTestCaseErrorLevel;`
`25`	`24`
`26`	`25`	`protected function setUp(): void`
`27`	`26`	`{`
`28`	`27`	`// Normalize intl. configuration settings.`
`29`	`28`	`if (\extension_loaded('intl')) {`
`30`	`29`	`$this->initialTestCaseUseException = ini_set('intl.use_exceptions', 0);`
`31`		`- $this->initialTestCaseErrorLevel = ini_set('intl.error_level', 0);`
`32`	`30`	`}`
`33`	`31`
`34`	`32`	`$this->defaultLocale = \Locale::getDefault();`
`@@ -41,7 +39,6 @@ protected function tearDown(): void`
`41`	`39`
`42`	`40`	`if (\extension_loaded('intl')) {`
`43`	`41`	`ini_set('intl.use_exceptions', $this->initialTestCaseUseException);`
`44`		`- ini_set('intl.error_level', $this->initialTestCaseErrorLevel);`
`45`	`42`	`}`
`46`	`43`	`}`
`47`	`44`
`@@ -664,6 +661,7 @@ public function testReverseTransformENotation($output, $input)`
`664`	`661`
`665`	`662`	`/**`
`666`	`663`	`* @requires extension intl`
	`664`	`+ * @requires PHP < 8.5`
`667`	`665`	`*/`
`668`	`666`	`public function testReverseTransformWrapsIntlErrorsWithErrorLevel()`
`669`	`667`	`{`
`@@ -696,6 +694,7 @@ public function testReverseTransformWrapsIntlErrorsWithExceptions()`
`696`	`694`
`697`	`695`	`/**`
`698`	`696`	`* @requires extension intl`
	`697`	`+ * @requires PHP < 8.5`
`699`	`698`	`*/`
`700`	`699`	`public function testReverseTransformWrapsIntlErrorsWithExceptionsAndErrorLevel()`
`701`	`700`	`{`
Original file line number	Diff line number	Diff line change
`@@ -21,14 +21,12 @@ class PercentToLocalizedStringTransformerTest extends TestCase`
`21`	`21`	`private string $defaultLocale;`
`22`	`22`
`23`	`23`	`private $initialTestCaseUseException;`
`24`		`- private $initialTestCaseErrorLevel;`
`25`	`24`
`26`	`25`	`protected function setUp(): void`
`27`	`26`	`{`
`28`	`27`	`// Normalize intl. configuration settings.`
`29`	`28`	`if (\extension_loaded('intl')) {`
`30`	`29`	`$this->initialTestCaseUseException = ini_set('intl.use_exceptions', 0);`
`31`		`- $this->initialTestCaseErrorLevel = ini_set('intl.error_level', 0);`
`32`	`30`	`}`
`33`	`31`
`34`	`32`	`$this->defaultLocale = \Locale::getDefault();`
`@@ -41,7 +39,6 @@ protected function tearDown(): void`
`41`	`39`
`42`	`40`	`if (\extension_loaded('intl')) {`
`43`	`41`	`ini_set('intl.use_exceptions', $this->initialTestCaseUseException);`
`44`		`- ini_set('intl.error_level', $this->initialTestCaseErrorLevel);`
`45`	`42`	`}`
`46`	`43`	`}`
`47`	`44`
`@@ -492,6 +489,7 @@ public function testReverseTransformForHtml5FormatWithScale()`
`492`	`489`
`493`	`490`	`/**`
`494`	`491`	`* @requires extension intl`
	`492`	`+ * @requires PHP < 8.5`
`495`	`493`	`*/`
`496`	`494`	`public function testReverseTransformWrapsIntlErrorsWithErrorLevel()`
`497`	`495`	`{`
`@@ -524,6 +522,7 @@ public function testReverseTransformWrapsIntlErrorsWithExceptions()`
`524`	`522`
`525`	`523`	`/**`
`526`	`524`	`* @requires extension intl`
	`525`	`+ * @requires PHP < 8.5`
`527`	`526`	`*/`
`528`	`527`	`public function testReverseTransformWrapsIntlErrorsWithExceptionsAndErrorLevel()`
`529`	`528`	`{`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,6 @@ public function reset(): void`
`83`	`83`	`foreach ($this->pushedResponses as $url => $response) {`
`84`	`84`	`$this->logger?->debug(\sprintf('Unused pushed response: "%s"', $url));`
`85`	`85`	`curl_multi_remove_handle($this->handle, $response->handle);`
`86`		`- curl_close($response->handle);`
`87`	`86`	`}`
`88`	`87`
`89`	`88`	`$this->pushedResponses = [];`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public function collect(Request $request, Response $response, ?\Throwable $excep`
`40`	`40`	`$this->data['redirect'] = true;`
`41`	`41`	`$this->data['url'] = $response->getTargetUrl();`
`42`	`42`
`43`		`- if ($this->controllers->contains($request)) {`
	`43`	`+ if ($this->controllers->offsetExists($request)) {`
`44`	`44`	`$this->data['route'] = $this->guessRoute($request, $this->controllers[$request]);`
`45`	`45`	`}`
`46`	`46`	`}`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ protected function getNextTransport(): ?TransportInterface`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`if ((microtime(true) - $this->deadTransports[$transport]) > $this->retryPeriod) {`
`87`		`- $this->deadTransports->detach($transport);`
	`87`	`+ unset($this->deadTransports[$transport]);`
`88`	`88`
`89`	`89`	`break;`
`90`	`90`	`}`
`@@ -101,7 +101,7 @@ protected function getNextTransport(): ?TransportInterface`
`101`	`101`
`102`	`102`	`protected function isTransportDead(TransportInterface $transport): bool`
`103`	`103`	`{`
`104`		`- return $this->deadTransports->contains($transport);`
	`104`	`+ return $this->deadTransports->offsetExists($transport);`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`protected function getInitialCursor(): int`