Skip to content

Commit b8eaa4b

Browse files
minor symfony#61805 Define DefinitionConfigurator generic type for AbstractBundle (alexander-schranz)
This PR was merged into the 7.4 branch. Discussion ---------- Define DefinitionConfigurator generic type for AbstractBundle | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | yes<!-- if yes, also update src/**/CHANGELOG.md --> | Deprecations? |no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md --> | Issues | Fix #... <!-- prefix each issue number with "Fix #"; no need to create an issue if none exists, explain below --> | License | MIT ### Why? Currently all `AbstractBundle` run into: ``` Method CmsIg\Seal\Integration\Symfony\SealBundle::configure() has parameter $definition with generic class Symfony\Component\Config\Definition\Configurator\DefinitionConfigurator but does not specify its types: T ------ ------------------------------------------------------------------------- Line src/SealBundle.php ------ ------------------------------------------------------------------------- 37 Method CmsIg\Seal\Integration\Symfony\SealBundle::configure() has parameter $definition with generic class Symfony\Component\Config\Definition\Configurator\DefinitionConfigurator but does not specify its types: T ------ ------------------------------------------------------------------------- ``` I not even sure what is the correct generic type here. If it is `'scalar'` or `'array'` so I think lot of people are not able to guess the correct one. So we should define the correct one for the AbstractBundle already. PHPDoc was added in symfony@8099cda by `@nicolas`-grekas Commits ------- d067cb3 Define DefinitionConfigurator generic type for AbstractBundle
2 parents 58f23d2 + d067cb3 commit b8eaa4b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Symfony/Component/Config/Definition/Configurator/DefinitionConfigurator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
use Symfony\Component\Config\Definition\Loader\DefinitionFileLoader;
1818

1919
/**
20-
* @template T of 'array'|'variable'|'scalar'|'string'|'boolean'|'integer'|'float'|'enum'
20+
* @template T of 'array'|'variable'|'scalar'|'string'|'boolean'|'integer'|'float'|'enum' = 'array'
2121
*
2222
* @author Yonel Ceruto <[email protected]>
2323
*/

0 commit comments

Comments
 (0)