Commit b8eaa4b
committed
minor symfony#61805 Define DefinitionConfigurator generic type for AbstractBundle (alexander-schranz)
This PR was merged into the 7.4 branch.
Discussion
----------
Define DefinitionConfigurator generic type for AbstractBundle
| Q | A
| ------------- | ---
| Branch? | 7.4
| Bug fix? | yes
| New feature? | yes<!-- if yes, also update src/**/CHANGELOG.md -->
| Deprecations? |no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md -->
| Issues | Fix #... <!-- prefix each issue number with "Fix #"; no need to create an issue if none exists, explain below -->
| License | MIT
### Why?
Currently all `AbstractBundle` run into:
```
Method CmsIg\Seal\Integration\Symfony\SealBundle::configure() has parameter $definition with generic class Symfony\Component\Config\Definition\Configurator\DefinitionConfigurator but does not specify its types: T
------ -------------------------------------------------------------------------
Line src/SealBundle.php
------ -------------------------------------------------------------------------
37 Method CmsIg\Seal\Integration\Symfony\SealBundle::configure() has
parameter $definition with generic class
Symfony\Component\Config\Definition\Configurator\DefinitionConfigurator
but does not specify its types: T
------ -------------------------------------------------------------------------
```
I not even sure what is the correct generic type here. If it is `'scalar'` or `'array'` so I think lot of people are not able to guess the correct one. So we should define the correct one for the AbstractBundle already.
PHPDoc was added in symfony@8099cda by `@nicolas`-grekas
Commits
-------
d067cb3 Define DefinitionConfigurator generic type for AbstractBundleFile tree
1 file changed
+1
-1
lines changed- src/Symfony/Component/Config/Definition/Configurator
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
0 commit comments