[Config] Use CPP

Author: OskarStark

src/Symfony/Component/Config/Builder/ClassBuilder.php

@@ -20,7 +20,6 @@
  */
 class ClassBuilder
 {
-    private string $namespace;
     private string $name;
 
     /** @var Property[] */
@@ -33,9 +32,10 @@ class ClassBuilder
     private array $implements = [];
     private bool $allowExtraKeys = false;
 
-    public function __construct(string $namespace, string $name)
-    {
-        $this->namespace = $namespace;
+    public function __construct(
+        private string $namespace,
+        string $name,
+    ) {
         $this->name = ucfirst($this->camelCase($name)).'Config';
     }
 

src/Symfony/Component/Config/Builder/ConfigBuilderGenerator.php

@@ -37,11 +37,10 @@ class ConfigBuilderGenerator implements ConfigBuilderGeneratorInterface
      * @var ClassBuilder[]
      */
     private array $classes = [];
-    private string $outputDir;
 
-    public function __construct(string $outputDir)
-    {
-        $this->outputDir = $outputDir;
+    public function __construct(
+        private string $outputDir,
+    ) {
     }
 
     /**

src/Symfony/Component/Config/Builder/Method.php

@@ -20,11 +20,9 @@
  */
 class Method
 {
-    private string $content;
-
-    public function __construct(string $content)
-    {
-        $this->content = $content;
+    public function __construct(
+        private string $content,
+    ) {
     }
 
     public function getContent(): string

src/Symfony/Component/Config/Builder/Property.php

@@ -20,17 +20,15 @@
  */
 class Property
 {
-    private string $name;
-    private string $originalName;
     private bool $array = false;
     private bool $scalarsAllowed = false;
     private ?string $type = null;
     private ?string $content = null;
 
-    public function __construct(string $originalName, string $name)
-    {
-        $this->name = $name;
-        $this->originalName = $originalName;
+    public function __construct(
+        private string $originalName,
+        private string $name,
+    ) {
     }
 
     public function getName(): string

src/Symfony/Component/Config/ConfigCache.php

@@ -25,16 +25,14 @@
  */
 class ConfigCache extends ResourceCheckerConfigCache
 {
-    private bool $debug;
-
     /**
      * @param string $file  The absolute cache path
      * @param bool   $debug Whether debugging is enabled or not
      */
-    public function __construct(string $file, bool $debug)
-    {
-        $this->debug = $debug;
-
+    public function __construct(
+        string $file,
+        private bool $debug,
+    ) {
         $checkers = [];
         if (true === $this->debug) {
             $checkers = [new SelfCheckingResourceChecker()];

src/Symfony/Component/Config/ConfigCacheFactory.php

@@ -22,14 +22,12 @@
  */
 class ConfigCacheFactory implements ConfigCacheFactoryInterface
 {
-    private bool $debug;
-
     /**
      * @param bool $debug The debug flag to pass to ConfigCache
      */
-    public function __construct(bool $debug)
-    {
-        $this->debug = $debug;
+    public function __construct(
+        private bool $debug,
+    ) {
     }
 
     public function cache(string $file, callable $callback): ConfigCacheInterface

src/Symfony/Component/Config/Definition/BaseNode.php

@@ -30,7 +30,6 @@ abstract class BaseNode implements NodeInterface
     private static array $placeholders = [];
 
     protected string $name;
-    protected ?NodeInterface $parent;
     protected array $normalizationClosures = [];
     protected array $normalizedTypes = [];
     protected array $finalValidationClosures = [];
@@ -39,22 +38,22 @@ abstract class BaseNode implements NodeInterface
     protected array $deprecation = [];
     protected array $equivalentValues = [];
     protected array $attributes = [];
-    protected string $pathSeparator;
 
     private mixed $handlingPlaceholder = null;
 
     /**
      * @throws \InvalidArgumentException if the name contains a period
      */
-    public function __construct(?string $name, NodeInterface $parent = null, string $pathSeparator = self::DEFAULT_PATH_SEPARATOR)
-    {
+    public function __construct(
+        ?string $name,
+        protected ?NodeInterface $parent = null,
+        protected string $pathSeparator = self::DEFAULT_PATH_SEPARATOR,
+    ) {
         if (str_contains($name = (string) $name, $pathSeparator)) {
             throw new \InvalidArgumentException('The name must not contain ".'.$pathSeparator.'".');
         }
 
         $this->name = $name;
-        $this->parent = $parent;
-        $this->pathSeparator = $pathSeparator;
     }
 
     /**

src/Symfony/Component/Config/Definition/Builder/ExprBuilder.php

@@ -30,11 +30,9 @@ class ExprBuilder
     public ?\Closure $ifPart = null;
     public ?\Closure $thenPart = null;
 
-    protected NodeDefinition $node;
-
-    public function __construct(NodeDefinition $node)
-    {
-        $this->node = $node;
+    public function __construct(
+        protected NodeDefinition $node,
+    ) {
     }
 
     /**

src/Symfony/Component/Config/Definition/Builder/MergeBuilder.php

@@ -21,11 +21,9 @@ class MergeBuilder
     public bool $allowFalse = false;
     public bool $allowOverwrite = true;
 
-    protected NodeDefinition $node;
-
-    public function __construct(NodeDefinition $node)
-    {
-        $this->node = $node;
+    public function __construct(
+        protected NodeDefinition $node,
+    ) {
     }
 
     /**

src/Symfony/Component/Config/Definition/Builder/NormalizationBuilder.php

@@ -22,11 +22,9 @@ class NormalizationBuilder
     public array $declaredTypes = [];
     public array $remappings = [];
 
-    protected NodeDefinition $node;
-
-    public function __construct(NodeDefinition $node)
-    {
-        $this->node = $node;
+    public function __construct(
+        protected NodeDefinition $node,
+    ) {
     }
 
     /**