bug symfony#59293 [AssetMapper] Fix JavaScript compiler creates self-referencing imports (smnandre)

This PR was merged into the 6.4 branch.

Discussion
----------

[AssetMapper] Fix JavaScript compiler creates self-referencing imports

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Issues        | Fix symfony#59289
| License       | MIT

Ignore self-referencing imports to avoid creating circular dependencies (and infinite parsing)

Commits
-------

d6ff6c1 [AssetMapper] Fix JavaScript compiler create self-referencing imports

Author: nicolas-grekas

src/Symfony/Component/AssetMapper/Compiler/JavaScriptImportPathCompiler.php

@@ -92,6 +92,11 @@ public function compile(string $content, MappedAsset $asset, AssetMapperInterfac
                 return $fullImportString;
             }
 
+            // Ignore self-referencing import
+            if ($dependentAsset->logicalPath === $asset->logicalPath) {
+                return $fullImportString;
+            }
+
             // List as a JavaScript import.
             // This will cause the asset to be included in the importmap (for relative imports)
             // and will be used to generate the preloads in the importmap.

src/Symfony/Component/AssetMapper/Tests/Compiler/JavaScriptImportPathCompilerTest.php

@@ -574,6 +574,34 @@ public function testCompileHandlesCircularBareImportAssets()
         $this->assertSame($popperAsset->logicalPath, $bootstrapAsset->getJavaScriptImports()[0]->assetLogicalPath);
     }
 
+    public function testCompileIgnoresSelfReferencingBareImportAssets()
+    {
+        $bootstrapAsset = new MappedAsset('foo.js', 'foo.js', 'foo.js');
+
+        $importMapConfigReader = $this->createMock(ImportMapConfigReader::class);
+        $importMapConfigReader->expects($this->once())
+            ->method('findRootImportMapEntry')
+            ->with('foobar')
+            ->willReturn(ImportMapEntry::createRemote('foobar', ImportMapType::JS, 'foo.js', '1.2.3', 'foobar', false));
+        $importMapConfigReader->expects($this->any())
+            ->method('convertPathToFilesystemPath')
+            ->with('foo.js')
+            ->willReturn('foo.js');
+
+        $assetMapper = $this->createMock(AssetMapperInterface::class);
+        $assetMapper->expects($this->once())
+            ->method('getAssetFromSourcePath')
+            ->with('foo.js')
+            ->willReturn($bootstrapAsset);
+
+        $compiler = new JavaScriptImportPathCompiler($importMapConfigReader);
+        $input = 'import { foo } from "foobar";';
+        $compiler->compile($input, $bootstrapAsset, $assetMapper);
+        $this->assertCount(0, $bootstrapAsset->getDependencies());
+        $this->assertCount(0, $bootstrapAsset->getFileDependencies());
+        $this->assertCount(0, $bootstrapAsset->getJavaScriptImports());
+    }
+
     /**
      * @dataProvider provideMissingImportModeTests
      */