minor symfony#61507 [Security] Preserve ordering of roles in RoleHierarchy (nicolas-grekas)

This PR was merged into the 7.4 branch.

Discussion
----------

[Security] Preserve ordering of roles in RoleHierarchy

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

As suggested in symfony#61057

/cc `@simonjamain`

Commits
-------

d4338b1 [Security] Preserve ordering of roles in RoleHierarchy

Author: fabpot

src/Symfony/Component/Security/Core/Role/RoleHierarchy.php

@@ -54,8 +54,11 @@ protected function buildRoleMap(): void
             $this->map[$main] = $roles;
             $visited = [];
             $additionalRoles = $roles;
-            while ($role = array_pop($additionalRoles)) {
+            while (null !== $role = key($additionalRoles)) {
+                $role = $additionalRoles[$role];
+
                 if (!isset($this->hierarchy[$role])) {
+                    next($additionalRoles);
                     continue;
                 }
 
@@ -68,6 +71,8 @@ protected function buildRoleMap(): void
                 foreach (array_diff($this->hierarchy[$role], $visited) as $additionalRole) {
                     $additionalRoles[] = $additionalRole;
                 }
+
+                next($additionalRoles);
             }
 
             $this->map[$main] = array_unique($this->map[$main]);