minor symfony#61202 [Console] cleanup (nicolas-grekas)

This PR was merged into the 7.4 branch.

Discussion
----------

[Console] cleanup

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

The argument already rejects/auto-casts booleans.

Commits
-------

a3eca77 [Console] cleanup

Author: chalasr

src/Symfony/Component/Console/Input/InputOption.php

@@ -79,7 +79,7 @@ public function __construct(
             throw new InvalidArgumentException('An option name cannot be empty.');
         }
 
-        if ('' === $shortcut || [] === $shortcut || false === $shortcut) {
+        if ('' === $shortcut || [] === $shortcut) {
             $shortcut = null;
         }
 

src/Symfony/Component/Console/Tests/Input/InputOptionTest.php

@@ -73,8 +73,6 @@ public function testShortcut()
         $this->assertSame('0|z', $option->getShortcut(), '-0 is an acceptable shortcut value when embedded in an array');
         $option = new InputOption('foo', '0|z');
         $this->assertSame('0|z', $option->getShortcut(), '-0 is an acceptable shortcut value when embedded in a string-list');
-        $option = new InputOption('foo', false);
-        $this->assertNull($option->getShortcut(), '__construct() makes the shortcut null when given a false as value');
     }
 
     public function testModes()