[Asset][BrowserKit][Cache][Console][CssSelector] Use CPP

Author: OskarStark

src/Symfony/Component/Asset/Context/RequestStackContext.php

@@ -20,15 +20,11 @@
  */
 class RequestStackContext implements ContextInterface
 {
-    private RequestStack $requestStack;
-    private string $basePath;
-    private bool $secure;
-
-    public function __construct(RequestStack $requestStack, string $basePath = '', bool $secure = false)
-    {
-        $this->requestStack = $requestStack;
-        $this->basePath = $basePath;
-        $this->secure = $secure;
+    public function __construct(
+        private RequestStack $requestStack,
+        private string $basePath = '',
+        private bool $secure = false,
+    ) {
     }
 
     public function getBasePath(): string

src/Symfony/Component/Asset/Package.php

@@ -23,12 +23,12 @@
  */
 class Package implements PackageInterface
 {
-    private VersionStrategyInterface $versionStrategy;
     private ContextInterface $context;
 
-    public function __construct(VersionStrategyInterface $versionStrategy, ContextInterface $context = null)
-    {
-        $this->versionStrategy = $versionStrategy;
+    public function __construct(
+        private VersionStrategyInterface $versionStrategy,
+        ContextInterface $context = null,
+    ) {
         $this->context = $context ?? new NullContext();
     }
 

src/Symfony/Component/Asset/Packages.php

@@ -22,16 +22,15 @@
  */
 class Packages
 {
-    private ?PackageInterface $defaultPackage;
     private array $packages = [];
 
     /**
      * @param PackageInterface[] $packages Additional packages indexed by name
      */
-    public function __construct(PackageInterface $defaultPackage = null, iterable $packages = [])
-    {
-        $this->defaultPackage = $defaultPackage;
-
+    public function __construct(
+        private ?PackageInterface $defaultPackage = null,
+        iterable $packages = [],
+    ) {
         foreach ($packages as $name => $package) {
             $this->addPackage($name, $package);
         }

src/Symfony/Component/Asset/VersionStrategy/JsonManifestVersionStrategy.php

@@ -31,21 +31,17 @@
  */
 class JsonManifestVersionStrategy implements VersionStrategyInterface
 {
-    private string $manifestPath;
     private array $manifestData;
-    private ?HttpClientInterface $httpClient;
-    private bool $strictMode;
 
     /**
      * @param string $manifestPath Absolute path to the manifest file
      * @param bool   $strictMode   Throws an exception for unknown paths
      */
-    public function __construct(string $manifestPath, HttpClientInterface $httpClient = null, bool $strictMode = false)
-    {
-        $this->manifestPath = $manifestPath;
-        $this->httpClient = $httpClient;
-        $this->strictMode = $strictMode;
-
+    public function __construct(
+        private string $manifestPath,
+        private ?HttpClientInterface $httpClient = null,
+        private bool $strictMode = false,
+    ) {
         if (null === $this->httpClient && ($scheme = parse_url($this->manifestPath, \PHP_URL_SCHEME)) && str_starts_with($scheme, 'http')) {
             throw new LogicException(sprintf('The "%s" class needs an HTTP client to use a remote manifest. Try running "composer require symfony/http-client".', self::class));
         }

src/Symfony/Component/Asset/VersionStrategy/StaticVersionStrategy.php

@@ -18,16 +18,16 @@
  */
 class StaticVersionStrategy implements VersionStrategyInterface
 {
-    private string $version;
     private string $format;
 
     /**
      * @param string $version Version number
      * @param string $format  Url format
      */
-    public function __construct(string $version, string $format = null)
-    {
-        $this->version = $version;
+    public function __construct(
+        private string $version,
+        string $format = null,
+    ) {
         $this->format = $format ?: '%s?%s';
     }
 

src/Symfony/Component/BrowserKit/Cookie.php

@@ -35,15 +35,10 @@ class Cookie
         'D M d H:i:s Y T',
     ];
 
-    protected string $name;
     protected string $value;
     protected ?string $expires = null;
     protected string $path;
-    protected string $domain;
-    protected bool $secure;
-    protected bool $httponly;
     protected string $rawValue;
-    private ?string $samesite;
 
     /**
      * Sets a cookie.
@@ -58,21 +53,25 @@ class Cookie
      * @param bool        $encodedValue Whether the value is encoded or not
      * @param string|null $samesite     The cookie samesite attribute
      */
-    public function __construct(string $name, ?string $value, string $expires = null, string $path = null, string $domain = '', bool $secure = false, bool $httponly = true, bool $encodedValue = false, string $samesite = null)
-    {
+    public function __construct(
+        private string $name,
+        ?string $value,
+        string $expires = null,
+        string $path = null,
+        private string $domain = '',
+        private bool $secure = false,
+        private bool $httponly = true,
+        bool $encodedValue = false,
+        private ?string $samesite = null,
+    ) {
         if ($encodedValue) {
             $this->rawValue = $value ?? '';
             $this->value = urldecode($this->rawValue);
         } else {
             $this->value = $value ?? '';
             $this->rawValue = rawurlencode($this->value);
         }
-        $this->name = $name;
         $this->path = empty($path) ? '/' : $path;
-        $this->domain = $domain;
-        $this->secure = $secure;
-        $this->httponly = $httponly;
-        $this->samesite = $samesite;
 
         if (null !== $expires) {
             $timestampAsDateTime = \DateTimeImmutable::createFromFormat('U', $expires);

src/Symfony/Component/BrowserKit/Request.php

@@ -16,37 +16,29 @@
  */
 class Request
 {
-    protected string $uri;
-    protected string $method;
-    protected array $parameters;
-    protected array $files;
-    protected array $cookies;
-    protected array $server;
-    protected ?string $content;
-
     /**
-     * @param string $uri        The request URI
-     * @param string $method     The HTTP method request
-     * @param array  $parameters The request parameters
-     * @param array  $files      An array of uploaded files
-     * @param array  $cookies    An array of cookies
-     * @param array  $server     An array of server parameters
-     * @param string $content    The raw body data
+     * @param string      $uri        The request URI
+     * @param string      $method     The HTTP method request
+     * @param array       $parameters The request parameters
+     * @param array       $files      An array of uploaded files
+     * @param array       $cookies    An array of cookies
+     * @param array       $server     An array of server parameters
+     * @param string|null $content    The raw body data
      */
-    public function __construct(string $uri, string $method, array $parameters = [], array $files = [], array $cookies = [], array $server = [], string $content = null)
-    {
-        $this->uri = $uri;
-        $this->method = $method;
-
+    public function __construct(
+        protected string $uri,
+        protected string $method,
+        protected array $parameters = [],
+        protected array $files = [],
+        protected array $cookies = [],
+        protected array $server = [],
+        protected ?string $content = null,
+    ) {
         array_walk_recursive($parameters, static function (&$value) {
             $value = (string) $value;
         });
 
         $this->parameters = $parameters;
-        $this->files = $files;
-        $this->cookies = $cookies;
-        $this->server = $server;
-        $this->content = $content;
     }
 
     /**

src/Symfony/Component/BrowserKit/Response.php

@@ -18,9 +18,6 @@
  */
 final class Response
 {
-    private string $content;
-    private int $status;
-    private array $headers;
     private array $jsonData;
 
     /**
@@ -31,11 +28,11 @@ final class Response
      * @param int    $status  The response status code (302 "Found" by default)
      * @param array  $headers An array of headers
      */
-    public function __construct(string $content = '', int $status = 200, array $headers = [])
-    {
-        $this->content = $content;
-        $this->status = $status;
-        $this->headers = $headers;
+    public function __construct(
+        private string $content = '',
+        private int $status = 200,
+        private array $headers = [],
+    ) {
     }
 
     /**

src/Symfony/Component/Cache/Adapter/ApcuAdapter.php

@@ -20,13 +20,15 @@
  */
 class ApcuAdapter extends AbstractAdapter
 {
-    private ?MarshallerInterface $marshaller;
-
     /**
      * @throws CacheException if APCu is not enabled
      */
-    public function __construct(string $namespace = '', int $defaultLifetime = 0, string $version = null, MarshallerInterface $marshaller = null)
-    {
+    public function __construct(
+        string $namespace = '',
+        int $defaultLifetime = 0,
+        string $version = null,
+        private ?MarshallerInterface $marshaller = null,
+    ) {
         if (!static::isSupported()) {
             throw new CacheException('APCu is not enabled.');
         }
@@ -43,8 +45,6 @@ public function __construct(string $namespace = '', int $defaultLifetime = 0, st
                 apcu_add($version.'@'.$namespace, null);
             }
         }
-
-        $this->marshaller = $marshaller;
     }
 
     public static function isSupported(): bool

src/Symfony/Component/Cache/Adapter/ArrayAdapter.php

@@ -30,21 +30,21 @@ class ArrayAdapter implements AdapterInterface, CacheInterface, LoggerAwareInter
 {
     use LoggerAwareTrait;
 
-    private bool $storeSerialized;
     private array $values = [];
     private array $tags = [];
     private array $expiries = [];
-    private int $defaultLifetime;
-    private float $maxLifetime;
-    private int $maxItems;
 
     private static \Closure $createCacheItem;
 
     /**
      * @param bool $storeSerialized Disabling serialization can lead to cache corruptions when storing mutable values but increases performance otherwise
      */
-    public function __construct(int $defaultLifetime = 0, bool $storeSerialized = true, float $maxLifetime = 0, int $maxItems = 0)
-    {
+    public function __construct(
+        private int $defaultLifetime = 0,
+        private bool $storeSerialized = true,
+        private float $maxLifetime = 0,
+        private int $maxItems = 0,
+    ) {
         if (0 > $maxLifetime) {
             throw new InvalidArgumentException(sprintf('Argument $maxLifetime must be positive, %F passed.', $maxLifetime));
         }
@@ -53,10 +53,6 @@ public function __construct(int $defaultLifetime = 0, bool $storeSerialized = tr
             throw new InvalidArgumentException(sprintf('Argument $maxItems must be a positive integer, %d passed.', $maxItems));
         }
 
-        $this->defaultLifetime = $defaultLifetime;
-        $this->storeSerialized = $storeSerialized;
-        $this->maxLifetime = $maxLifetime;
-        $this->maxItems = $maxItems;
         self::$createCacheItem ??= \Closure::bind(
             static function ($key, $value, $isHit, $tags) {
                 $item = new CacheItem();