bug symfony#58626 [BrowserKit][FrameworkBundle] do not access typed properties before initialization (xabbuh)

This PR was merged into the 7.1 branch.

Discussion
----------

[BrowserKit][FrameworkBundle] do not access typed properties before initialization

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Commits
-------

1a7278e do not access typed properties before initialization

Author: nicolas-grekas

src/Symfony/Bundle/FrameworkBundle/KernelBrowser.php

@@ -56,7 +56,7 @@ public function getKernel(): KernelInterface
      */
     public function getProfile(): HttpProfile|false|null
     {
-        if (null === $this->response || !$this->getContainer()->has('profiler')) {
+        if (!isset($this->response) || !$this->getContainer()->has('profiler')) {
             return false;
         }
 

src/Symfony/Bundle/FrameworkBundle/Tests/KernelBrowserTest.php

@@ -14,6 +14,7 @@
 use Symfony\Bundle\FrameworkBundle\KernelBrowser;
 use Symfony\Bundle\FrameworkBundle\Tests\Functional\AbstractWebTestCase;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpKernel\KernelInterface;
 
 class KernelBrowserTest extends AbstractWebTestCase
 {
@@ -61,6 +62,13 @@ public function testRequestAfterKernelShutdownAndPerformedRequest()
         $client->request('GET', '/');
     }
 
+    public function testGetProfileWithoutRequest()
+    {
+        $browser = new KernelBrowser($this->createMock(KernelInterface::class));
+
+        $this->assertFalse($browser->getProfile());
+    }
+
     private function getKernelMock()
     {
         $mock = $this->getMockBuilder($this->getKernelClass())

src/Symfony/Component/BrowserKit/AbstractBrowser.php

@@ -531,7 +531,7 @@ public function reload(): Crawler
      */
     public function followRedirect(): Crawler
     {
-        if (!$this->redirect) {
+        if (!isset($this->redirect)) {
             throw new LogicException('The request was not redirected.');
         }
 

src/Symfony/Component/BrowserKit/Tests/AbstractBrowserTest.php

@@ -15,6 +15,7 @@
 use Symfony\Component\BrowserKit\CookieJar;
 use Symfony\Component\BrowserKit\Exception\BadMethodCallException;
 use Symfony\Component\BrowserKit\Exception\InvalidArgumentException;
+use Symfony\Component\BrowserKit\Exception\LogicException;
 use Symfony\Component\BrowserKit\History;
 use Symfony\Component\BrowserKit\Request;
 use Symfony\Component\BrowserKit\Response;
@@ -889,4 +890,14 @@ public function testInternalRequestNull()
 
         $client->getInternalRequest();
     }
+
+    public function testFollowRedirectWithoutRequest()
+    {
+        $browser = $this->getBrowser();
+
+        $this->expectException(LogicException::class);
+        $this->expectExceptionMessage('The request was not redirected.');
+
+        $browser->followRedirect();
+    }
 }