minor symfony#58982 [HttpClient] Remove unrelevant test (alexandre-daubois)

nicolas-grekas · nicolas-grekas · commit d9ab65448bc9 · 2024-11-25T16:15:40.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [HttpClient] Remove unrelevant test | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Subnets argument of `NoPrivateNetworkHttpClient` is now typed so the `TypeError` cannot happen. Commits ------- f67e921 [HttpClient] Remove unrelevant test
diff --git a/src/Symfony/Component/HttpClient/Tests/NoPrivateNetworkHttpClientTest.php b/src/Symfony/Component/HttpClient/Tests/NoPrivateNetworkHttpClientTest.php
@@ -142,14 +142,6 @@ public function testNonCallableOnProgressCallback()
         $client->request('GET', $url, ['on_progress' => $customCallback]);
     }
 
-    public function testConstructor()
-    {
-        $this->expectException(\TypeError::class);
-        $this->expectExceptionMessage('Argument 2 passed to "Symfony\Component\HttpClient\NoPrivateNetworkHttpClient::__construct()" must be of the type array, string or null. "int" given.');
-
-        new NoPrivateNetworkHttpClient(new MockHttpClient(), 3);
-    }
-
     private function getMockHttpClient(string $ipAddr, string $content)
     {
         return new MockHttpClient(new MockResponse($content, ['primary_ip' => $ipAddr]));

Original file line number	Diff line number	Diff line change
`@@ -142,14 +142,6 @@ public function testNonCallableOnProgressCallback()`
`142`	`142`	`$client->request('GET', $url, ['on_progress' => $customCallback]);`
`143`	`143`	`}`
`144`	`144`
`145`		`- public function testConstructor()`
`146`		`- {`
`147`		`- $this->expectException(\TypeError::class);`
`148`		`- $this->expectExceptionMessage('Argument 2 passed to "Symfony\Component\HttpClient\NoPrivateNetworkHttpClient::__construct()" must be of the type array, string or null. "int" given.');`
`149`		`-`
`150`		`- new NoPrivateNetworkHttpClient(new MockHttpClient(), 3);`
`151`		`- }`
`152`		`-`
`153`	`145`	`private function getMockHttpClient(string $ipAddr, string $content)`
`154`	`146`	`{`
`155`	`147`	`return new MockHttpClient(new MockResponse($content, ['primary_ip' => $ipAddr]));`