bug symfony#61194 [Security] Fix added $token argument to UserCheckerInterface::checkPostAuth() (nicolas-grekas)

This PR was merged into the 7.2 branch.

Discussion
----------

[Security] Fix added $token argument to UserCheckerInterface::checkPostAuth()

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

An added argument must be optional and must be declared using ``@param``, which will allow spotting all places that have to be updated in cascade. This PR fixes all that. Not sure how we messed up so badly in symfony#57773 😅

Commits
-------

c819110 [Security] Fix added $token argument to UserCheckerInterface::checkPostAuth()

Author: nicolas-grekas

src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/SecurityExtensionTest.php

@@ -986,7 +986,7 @@ public function checkPreAuth(UserInterface $user): void
     {
     }
 
-    public function checkPostAuth(UserInterface $user): void
+    public function checkPostAuth(UserInterface $user, ?TokenInterface $token = null): void
     {
     }
 }

src/Symfony/Component/Security/Core/User/ChainUserChecker.php

@@ -29,16 +29,15 @@ public function checkPreAuth(UserInterface $user): void
         }
     }
 
-    public function checkPostAuth(UserInterface $user /* , TokenInterface $token */): void
+    /**
+     * @param ?TokenInterface $token
+     */
+    public function checkPostAuth(UserInterface $user /* , ?TokenInterface $token = null */): void
     {
         $token = 1 < \func_num_args() ? func_get_arg(1) : null;
 
         foreach ($this->checkers as $checker) {
-            if ($token instanceof TokenInterface) {
-                $checker->checkPostAuth($user, $token);
-            } else {
-                $checker->checkPostAuth($user);
-            }
+            $checker->checkPostAuth($user, $token);
         }
     }
 }

src/Symfony/Component/Security/Core/User/InMemoryUserChecker.php

@@ -33,7 +33,10 @@ public function checkPreAuth(UserInterface $user): void
         }
     }
 
-    public function checkPostAuth(UserInterface $user): void
+    /**
+     * @param ?TokenInterface $token
+     */
+    public function checkPostAuth(UserInterface $user /* , ?TokenInterface $token = null */): void
     {
     }
 }

src/Symfony/Component/Security/Core/User/UserCheckerInterface.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Security\Core\User;
 
+use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 use Symfony\Component\Security\Core\Exception\AccountStatusException;
 
 /**
@@ -33,7 +34,9 @@ public function checkPreAuth(UserInterface $user): void;
     /**
      * Checks the user account after authentication.
      *
+     * @param ?TokenInterface $token
+     *
      * @throws AccountStatusException
      */
-    public function checkPostAuth(UserInterface $user /* , TokenInterface $token */): void;
+    public function checkPostAuth(UserInterface $user /* , ?TokenInterface $token = null */): void;
 }