Commit daca45f
committed
minor symfony#53184 [DoctrineBridge] Adapt deprecation message to include ODM bundle attribute name (GromNaN)
This PR was squashed before being merged into the 6.3 branch.
Discussion
----------
[DoctrineBridge] Adapt deprecation message to include ODM bundle attribute name
| Q | A
| ------------- | ---
| Branch? | 6.3
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Issues | Refs doctrine/DoctrineMongoDBBundle#816
| License | MIT
In `DoctrineMongoDBBundle`, the attribute to register event listeners is called `AsDocumentListener`, not `AsDoctrineListener` like in `DoctrineBundle`. (see [exploration details](doctrine/DoctrineMongoDBBundle#817 (comment)))
In order to not confuse developers updating their application with the wrong attribute name, this PR adapts the message to the context.
- in `RegisterEventListenersAndSubscribersPass`, it's simple to check [the tagPrefix provided by the bundle](https://github.com/doctrine/DoctrineMongoDBBundle/blob/7fa2155aed7254f17b14182e8568284f45e33034/DoctrineMongoDBBundle.php#L41).
- in `ContainerAwareEventManager`, I havent found anything to provide context. So I removed the attribute name from the message.
Commits
-------
56d4263 [DoctrineBridge] Adapt deprecation message to include ODM bundle attribute nameFile tree
3 files changed
+7
-7
lines changed- src/Symfony/Bridge/Doctrine
- DependencyInjection/CompilerPass
- Tests
3 files changed
+7
-7
lines changedLines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
207 | 207 | | |
208 | 208 | | |
209 | 209 | | |
210 | | - | |
211 | | - | |
| 210 | + | |
| 211 | + | |
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
109 | | - | |
| 109 | + | |
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
| |||
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | | - | |
| 95 | + | |
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
| |||
177 | 177 | | |
178 | 178 | | |
179 | 179 | | |
180 | | - | |
| 180 | + | |
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
| |||
238 | 238 | | |
239 | 239 | | |
240 | 240 | | |
241 | | - | |
| 241 | + | |
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
| |||
0 commit comments