minor symfony#58058 [Form] Remove stalled PHP bug mentions (alexandre-daubois)

This PR was merged into the 7.2 branch.

Discussion
----------

[Form] Remove stalled PHP bug mentions

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

The [bug linked](https://bugs.php.net/bug.php?id=66323) in these occurrences is stalled: https://3v4l.org/hC1MO. It now throws an exception on invalid timezone.

In `DateTimeToLocalizedStringTransformer`,  the exception cannot be thrown because timezone are check in the parent constructor call.

In `DateType`, passing `null` to `timezone` results on using the default locale.

Commits
-------

e688419 [Form] Remove stalled PHP bug mentions

Author: nicolas-grekas

src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformer.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Form\Extension\Core\DataTransformer;
 
+use Symfony\Component\Form\Exception\InvalidArgumentException;
 use Symfony\Component\Form\Exception\TransformationFailedException;
 use Symfony\Component\Form\Exception\UnexpectedTypeException;
 
@@ -60,6 +61,10 @@ public function __construct(
             throw new UnexpectedTypeException($timeFormat, implode('", "', self::$formats));
         }
 
+        if (\is_int($calendar) && !\in_array($calendar, [\IntlDateFormatter::GREGORIAN, \IntlDateFormatter::TRADITIONAL], true)) {
+            throw new InvalidArgumentException('The "calendar" option should be either an \IntlDateFormatter constant or an \IntlCalendar instance.');
+        }
+
         $this->dateFormat = $dateFormat;
         $this->timeFormat = $timeFormat;
     }
@@ -157,8 +162,6 @@ public function reverseTransform(mixed $value): ?\DateTime
      * Returns a preconfigured IntlDateFormatter instance.
      *
      * @param bool $ignoreTimezone Use UTC regardless of the configured timezone
-     *
-     * @throws TransformationFailedException in case the date formatter cannot be constructed
      */
     protected function getIntlDateFormatter(bool $ignoreTimezone = false): \IntlDateFormatter
     {
@@ -170,12 +173,6 @@ protected function getIntlDateFormatter(bool $ignoreTimezone = false): \IntlDate
         $pattern = $this->pattern;
 
         $intlDateFormatter = new \IntlDateFormatter(\Locale::getDefault(), $dateFormat, $timeFormat, $timezone, $calendar, $pattern ?? '');
-
-        // new \intlDateFormatter may return null instead of false in case of failure, see https://bugs.php.net/66323
-        if (!$intlDateFormatter) {
-            throw new TransformationFailedException(intl_get_error_message(), intl_get_error_code());
-        }
-
         $intlDateFormatter->setLenient(false);
 
         return $intlDateFormatter;

src/Symfony/Component/Form/Extension/Core/Type/DateType.php

@@ -120,17 +120,11 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
                 \Locale::getDefault(),
                 $dateFormat,
                 $timeFormat,
-                // see https://bugs.php.net/66323
-                class_exists(\IntlTimeZone::class, false) ? \IntlTimeZone::createDefault() : null,
+                null,
                 $calendar,
                 $pattern
             );
 
-            // new \IntlDateFormatter may return null instead of false in case of failure, see https://bugs.php.net/66323
-            if (!$formatter) {
-                throw new InvalidOptionsException(intl_get_error_message(), intl_get_error_code());
-            }
-
             $formatter->setLenient(false);
 
             if ('choice' === $options['widget']) {

src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformerTest.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Form\Tests\Extension\Core\DataTransformer;
 
+use Symfony\Component\Form\Exception\InvalidArgumentException;
 use Symfony\Component\Form\Exception\TransformationFailedException;
 use Symfony\Component\Form\Extension\Core\DataTransformer\BaseDateTimeTransformer;
 use Symfony\Component\Form\Extension\Core\DataTransformer\DateTimeToLocalizedStringTransformer;
@@ -446,6 +447,14 @@ public function testDefaultCalendarIsGregorian()
         );
     }
 
+    public function testInvalidCalendar()
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('The "calendar" option should be either an \IntlDateFormatter constant or an \IntlCalendar instance.');
+
+        new DateTimeToLocalizedStringTransformer(calendar: 123456);
+    }
+
     protected function createDateTimeTransformer(?string $inputTimezone = null, ?string $outputTimezone = null): BaseDateTimeTransformer
     {
         return new DateTimeToLocalizedStringTransformer($inputTimezone, $outputTimezone);