bug symfony#59308 [JsonEncoder] Fix encoding of dictionary with integer keys (mtarld)

This PR was merged into the 7.3 branch.

Discussion
----------

[JsonEncoder] Fix encoding of dictionary with integer keys

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Fix encoding of dictionary with integer keys.

Previously, `[1 => true, 2 => false]` was encoded to `{"": true, "": false}`, now it is encoded to `{"1": true, "2": false}`.

Also improve test coverage about list, dictionaries and iterable.

Commits
-------

9983379 [JsonEncoder] Fix associative collection consideration

Author: fabpot

src/Symfony/Component/JsonEncoder/Encode/PhpAstBuilder.php

@@ -196,13 +196,17 @@ private function buildClosureStatements(DataModelNodeInterface $dataModelNode, a
                 ];
             }
 
+            $escapedKey = $dataModelNode->getType()->getCollectionKeyType()->isIdentifiedBy(TypeIdentifier::INT)
+                ? new Ternary($this->builder->funcCall('is_int', [$this->builder->var('key')]), $this->builder->var('key'), $this->escapeString($this->builder->var('key')))
+                : $this->escapeString($this->builder->var('key'));
+
             return [
                 new Expression(new Yield_($this->builder->val('{'))),
                 new Expression(new Assign($this->builder->var('prefix'), $this->builder->val(''))),
                 new Foreach_($accessor, $dataModelNode->getItemNode()->getAccessor()->toPhpExpr(), [
                     'keyVar' => $this->builder->var('key'),
                     'stmts' => [
-                        new Expression(new Assign($this->builder->var('key'), $this->escapeString($this->builder->var('key')))),
+                        new Expression(new Assign($this->builder->var('key'), $escapedKey)),
                         new Expression(new Yield_(new Encapsed([
                             $this->builder->var('prefix'),
                             new EncapsedStringPart('"'),

src/Symfony/Component/JsonEncoder/Tests/Decode/DecoderGeneratorTest.php

@@ -95,12 +95,13 @@ public static function generatedDecoderDataProvider(): iterable
         yield ['list', Type::list()];
         yield ['object_list', Type::list(Type::object(ClassicDummy::class))];
         yield ['nullable_object_list', Type::nullable(Type::list(Type::object(ClassicDummy::class)))];
-        yield ['iterable_list', Type::iterable(key: Type::int(), asList: true)];
 
         yield ['dict', Type::dict()];
         yield ['object_dict', Type::dict(Type::object(ClassicDummy::class))];
         yield ['nullable_object_dict', Type::nullable(Type::dict(Type::object(ClassicDummy::class)))];
-        yield ['iterable_dict', Type::iterable(key: Type::string())];
+
+        yield ['iterable', Type::iterable()];
+        yield ['object_iterable', Type::iterable(Type::object(ClassicDummy::class))];
 
         yield ['object', Type::object(ClassicDummy::class)];
         yield ['nullable_object', Type::nullable(Type::object(ClassicDummy::class))];

src/Symfony/Component/JsonEncoder/Tests/Encode/EncoderGeneratorTest.php

@@ -21,6 +21,7 @@
 use Symfony\Component\JsonEncoder\Mapping\PropertyMetadataLoaderInterface;
 use Symfony\Component\JsonEncoder\Tests\Fixtures\Enum\DummyBackedEnum;
 use Symfony\Component\JsonEncoder\Tests\Fixtures\Enum\DummyEnum;
+use Symfony\Component\JsonEncoder\Tests\Fixtures\Model\ClassicDummy;
 use Symfony\Component\JsonEncoder\Tests\Fixtures\Model\DummyWithNameAttributes;
 use Symfony\Component\JsonEncoder\Tests\Fixtures\Model\DummyWithNormalizerAttributes;
 use Symfony\Component\JsonEncoder\Tests\Fixtures\Model\DummyWithOtherDummies;
@@ -92,12 +93,12 @@ public static function generatedEncoderDataProvider(): iterable
         yield ['object_list', Type::list(Type::object(DummyWithNameAttributes::class))];
         yield ['nullable_object_list', Type::nullable(Type::list(Type::object(DummyWithNameAttributes::class)))];
 
-        yield ['iterable_list', Type::iterable(key: Type::int(), asList: true)];
-
         yield ['dict', Type::dict()];
         yield ['object_dict', Type::dict(Type::object(DummyWithNameAttributes::class))];
         yield ['nullable_object_dict', Type::nullable(Type::dict(Type::object(DummyWithNameAttributes::class)))];
-        yield ['iterable_dict', Type::iterable(key: Type::string())];
+
+        yield ['iterable', Type::iterable()];
+        yield ['object_iterable', Type::iterable(Type::object(ClassicDummy::class))];
 
         yield ['object', Type::object(DummyWithNameAttributes::class)];
         yield ['nullable_object', Type::nullable(Type::object(DummyWithNameAttributes::class))];