minor symfony#61347 [DomCrawler] [Tests] Adapt testAddHtmlContentWithErrors to be HTML5 compliant (renanrodrigo)

nicolas-grekas · nicolas-grekas · commit e6cad902ee9e · 2025-08-06T22:11:57.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [DomCrawler] [Tests] Adapt testAddHtmlContentWithErrors to be HTML5 compliant | Q | A | ------------- | --- | Branch? |6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix symfony#61346 | License | MIT - What it does and why it's needed The new libxml2 uses HTML5 by default, and the current snippet used to test invalid HTML is HTML5-valid. This commit changes the snippet to be invalid both for HTML4 and HTML5, so the test passes. - A simple example of how it works (include PHP, YAML, etc.) - Running the test suite using a `php` build compiled against `libxml2` < `2.14` should keep working - Running the test suite using a `php` build compiled against `libxml2` >= `2.14` should now work - If it modifies existing behavior, include a before/after comparison It does not. Commits ------- 3c0410b [Tests] Adapt testAddHtmlContentWithErrors to be HTML5 compliant
diff --git a/src/Symfony/Component/DomCrawler/Tests/NativeParserCrawlerTest.php b/src/Symfony/Component/DomCrawler/Tests/NativeParserCrawlerTest.php
@@ -29,15 +29,16 @@ public function testAddHtmlContentWithErrors()
     <head>
     </head>
     <body>
-        <nav><a href="#"><a href="#"></nav>
+        <div><a href="#"></div>
+    </body>
     </body>
 </html>
 EOF
             , 'UTF-8');
 
         $errors = libxml_get_errors();
         $this->assertCount(1, $errors);
-        $this->assertEquals("Tag nav invalid\n", $errors[0]->message);
+        $this->assertEquals("Unexpected end tag : body\n", $errors[0]->message);
 
         libxml_clear_errors();
         libxml_use_internal_errors($internalErrors);
