bug symfony#61548 [Security] Fix attribute-based chained user providers (valtzu)

This PR was merged into the 6.4 branch.

Discussion
----------

[Security] Fix attribute-based chained user providers

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT

The attributes were not passed to an attribute-based user provider (`AttributesBasedUserProviderInterface`) in a `UserProviderChain`.

On 7.4 we could make `ChainUserProvider` implement `AttributesBasedUserProviderInterface`.

Commits
-------

8169616 [Security] Fix attribute-based chained user providers

Author: fabpot

src/Symfony/Component/Security/Core/Tests/User/ChainUserProviderTest.php

@@ -14,12 +14,14 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Security\Core\Exception\UnsupportedUserException;
 use Symfony\Component\Security\Core\Exception\UserNotFoundException;
+use Symfony\Component\Security\Core\User\AttributesBasedUserProviderInterface;
 use Symfony\Component\Security\Core\User\ChainUserProvider;
 use Symfony\Component\Security\Core\User\InMemoryUser;
 use Symfony\Component\Security\Core\User\InMemoryUserProvider;
 use Symfony\Component\Security\Core\User\PasswordAuthenticatedUserInterface;
 use Symfony\Component\Security\Core\User\PasswordUpgraderInterface;
 use Symfony\Component\Security\Core\User\UserInterface;
+use Symfony\Component\Security\Core\User\UserProviderInterface;
 
 class ChainUserProviderTest extends TestCase
 {
@@ -45,6 +47,28 @@ public function testLoadUserByIdentifier()
         $this->assertSame($account, $provider->loadUserByIdentifier('foo'));
     }
 
+    public function testLoadUserByIdentifierWithAttributes()
+    {
+        $provider1 = $this->createMock(UserProviderInterface::class);
+        $provider1
+            ->expects($this->once())
+            ->method('loadUserByIdentifier')
+            ->with($this->equalTo('foo'))
+            ->willThrowException(new UserNotFoundException('not found'))
+        ;
+
+        $provider2 = $this->createMock(AttributesBasedUserProviderInterface::class);
+        $provider2
+            ->expects($this->once())
+            ->method('loadUserByIdentifier')
+            ->with($this->equalTo('foo'), $this->equalTo(['attr' => 5]))
+            ->willReturn($account = $this->createMock(UserInterface::class))
+        ;
+
+        $provider = new ChainUserProvider([$provider1, $provider2]);
+        $this->assertSame($account, $provider->loadUserByIdentifier('foo', ['attr' => 5]));
+    }
+
     public function testLoadUserByIdentifierThrowsUserNotFoundException()
     {
         $this->expectException(UserNotFoundException::class);

src/Symfony/Component/Security/Core/User/ChainUserProvider.php

@@ -56,10 +56,18 @@ public function loadUserByUsername(string $username): UserInterface
         return $this->loadUserByIdentifier($username);
     }
 
-    public function loadUserByIdentifier(string $identifier): UserInterface
+    /**
+     * @param array $attributes
+     */
+    public function loadUserByIdentifier(string $identifier/* , array $attributes = [] */): UserInterface
     {
+        $attributes = \func_num_args() > 1 ? func_get_arg(1) : [];
         foreach ($this->providers as $provider) {
             try {
+                if ($provider instanceof AttributesBasedUserProviderInterface) {
+                    return $provider->loadUserByIdentifier($identifier, $attributes);
+                }
+
                 return $provider->loadUserByIdentifier($identifier);
             } catch (UserNotFoundException) {
                 // try next one