minor symfony#61107 optimize in_array calls (gharlan)

This PR was squashed before being merged into the 7.4 branch.

Discussion
----------

optimize `in_array` calls

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

`in_array` calls are optimized by php when fully-qualified and using a static array and the strict param:

```php
namespace Foo;

$a = [1, 2, 3];
\in_array($b, $a, true); // not optimized because variable array

\in_array($b, [1, 2, 3]); // not optimized because missing strict param

in_array($b, [1, 2, 3], true); // not optimized because no leading `\` or import

\in_array($b, [1, 2, 3], true); // optimized
```

https://3v4l.org/FjKJ0/vld
You can see in the "VLD" tab that lines 6, 8 and 10 use the function call opcodes (`INIT_FCALL` or `INIT_NS_FCALL_BY_NAME`) while line 12 uses the optimized `IN_ARRAY` opcode without a function call.

In this pull request I changed only those places where the change enables the optimized opcode (by adding the strict param or inlining the array).

Commits
-------

33157f7 optimize `in_array` calls

Author: nicolas-grekas

src/Symfony/Bridge/Doctrine/DependencyInjection/AbstractDoctrineExtension.php

@@ -153,7 +153,7 @@ protected function getMappingDriverBundleConfigDefaults(array $bundleConfig, \Re
         }
 
         if (!$bundleConfig['dir']) {
-            if (\in_array($bundleConfig['type'], ['staticphp', 'attribute'])) {
+            if (\in_array($bundleConfig['type'], ['staticphp', 'attribute'], true)) {
                 $bundleConfig['dir'] = $bundleClassDir.'/'.$this->getMappingObjectDefaultName();
             } else {
                 $bundleConfig['dir'] = $bundleDir.'/'.$this->getMappingResourceConfigDirectory($bundleDir);
@@ -225,7 +225,7 @@ protected function assertValidMappingConfiguration(array $mappingConfig, string
             throw new \InvalidArgumentException(\sprintf('Specified non-existing directory "%s" as Doctrine mapping source.', $mappingConfig['dir']));
         }
 
-        if (!\in_array($mappingConfig['type'], ['xml', 'yml', 'php', 'staticphp', 'attribute'])) {
+        if (!\in_array($mappingConfig['type'], ['xml', 'yml', 'php', 'staticphp', 'attribute'], true)) {
             throw new \InvalidArgumentException(\sprintf('Can only configure "xml", "yml", "php", "staticphp" or "attribute" through the DoctrineBundle. Use your own bundle to configure other metadata drivers. You can register them by adding a new driver to the "%s" service definition.', $this->getObjectManagerElementName($objectManagerName.'_metadata_driver')));
         }
     }

src/Symfony/Bridge/Doctrine/Form/ChoiceList/IdReader.php

@@ -48,7 +48,7 @@ public function __construct(
             $singleId = $this->associationIdReader->isSingleId();
             $this->intId = $this->associationIdReader->isIntId();
         } else {
-            $this->intId = $singleId && \in_array($idType, ['integer', 'smallint', 'bigint']);
+            $this->intId = $singleId && \in_array($idType, ['integer', 'smallint', 'bigint'], true);
             $this->associationIdReader = null;
         }
 

src/Symfony/Bridge/Doctrine/Form/ChoiceList/ORMQueryBuilderLoader.php

@@ -61,13 +61,13 @@ public function getEntitiesByIds(string $identifier, array $values): array
         // Guess type
         $entity = current($qb->getRootEntities());
         $metadata = $qb->getEntityManager()->getClassMetadata($entity);
-        if (\in_array($type = $metadata->getTypeOfField($identifier), ['integer', 'bigint', 'smallint'])) {
+        if (\in_array($type = $metadata->getTypeOfField($identifier), ['integer', 'bigint', 'smallint'], true)) {
             $parameterType = ArrayParameterType::INTEGER;
 
             // Filter out non-integer values (e.g. ""). If we don't, some
             // databases such as PostgreSQL fail.
             $values = array_values(array_filter($values, fn ($v) => (string) $v === (string) (int) $v || ctype_digit($v)));
-        } elseif (\in_array($type, ['ulid', 'uuid', 'guid'])) {
+        } elseif (\in_array($type, ['ulid', 'uuid', 'guid'], true)) {
             $parameterType = ArrayParameterType::STRING;
 
             // Like above, but we just filter out empty strings.

src/Symfony/Bridge/Doctrine/Form/DoctrineOrmTypeGuesser.php

@@ -134,7 +134,7 @@ public function guessMaxLength(string $class, string $property): ?ValueGuess
                 return new ValueGuess($length, Guess::HIGH_CONFIDENCE);
             }
 
-            if (\in_array($ret[0]->getTypeOfField($property), [Types::DECIMAL, Types::FLOAT])) {
+            if (\in_array($ret[0]->getTypeOfField($property), [Types::DECIMAL, Types::FLOAT], true)) {
                 return new ValueGuess(null, Guess::MEDIUM_CONFIDENCE);
             }
         }
@@ -146,7 +146,7 @@ public function guessPattern(string $class, string $property): ?ValueGuess
     {
         $ret = $this->getMetadata($class);
         if ($ret && isset($ret[0]->fieldMappings[$property]) && !$ret[0]->hasAssociation($property)) {
-            if (\in_array($ret[0]->getTypeOfField($property), [Types::DECIMAL, Types::FLOAT])) {
+            if (\in_array($ret[0]->getTypeOfField($property), [Types::DECIMAL, Types::FLOAT], true)) {
                 return new ValueGuess(null, Guess::MEDIUM_CONFIDENCE);
             }
         }

src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php

@@ -213,7 +213,7 @@ private function isNfs(string $dir): bool
             if ('/' === \DIRECTORY_SEPARATOR && @is_readable('/proc/mounts') && $files = @file('/proc/mounts')) {
                 foreach ($files as $mount) {
                     $mount = \array_slice(explode(' ', $mount), 1, -3);
-                    if (!\in_array(array_pop($mount), ['vboxsf', 'nfs'])) {
+                    if (!\in_array(array_pop($mount), ['vboxsf', 'nfs'], true)) {
                         continue;
                     }
                     $mounts[] = implode(' ', $mount).'/';

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php

@@ -2563,7 +2563,7 @@ private function addRateLimiterSection(ArrayNodeDefinition $rootNode, callable $
                                     ->end()
                                 ->end()
                                 ->validate()
-                                    ->ifTrue(static fn ($v) => !\in_array($v['policy'], ['no_limit', 'compound']) && !isset($v['limit']))
+                                    ->ifTrue(static fn ($v) => !\in_array($v['policy'], ['no_limit', 'compound'], true) && !isset($v['limit']))
                                     ->thenInvalid('A limit must be provided when using a policy different than "compound" or "no_limit".')
                                 ->end()
                             ->end()

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

@@ -2053,7 +2053,7 @@ private function registerSerializerConfiguration(array $config, ContainerBuilder
         }
 
         $fileRecorder = function ($extension, $path) use (&$serializerLoaders) {
-            $definition = new Definition(\in_array($extension, ['yaml', 'yml']) ? YamlFileLoader::class : XmlFileLoader::class, [$path]);
+            $definition = new Definition(\in_array($extension, ['yaml', 'yml'], true) ? YamlFileLoader::class : XmlFileLoader::class, [$path]);
             $serializerLoaders[] = $definition;
         };
 
@@ -2935,7 +2935,7 @@ private function registerMailerConfiguration(array $config, ContainerBuilder $co
             $headers = new Definition(Headers::class);
             foreach ($config['headers'] as $name => $data) {
                 $value = $data['value'];
-                if (\in_array(strtolower($name), ['from', 'to', 'cc', 'bcc', 'reply-to'])) {
+                if (\in_array(strtolower($name), ['from', 'to', 'cc', 'bcc', 'reply-to'], true)) {
                     $value = (array) $value;
                 }
                 $headers->addMethodCall('addHeader', [$name, $value]);

src/Symfony/Bundle/TwigBundle/Tests/DependencyInjection/TwigExtensionTest.php

@@ -92,7 +92,7 @@ public function testLoadFullConfiguration(string $format, ?string $buildDir)
         $this->assertEquals(3.14, $calls[4][1][1], '->load() registers variables as Twig globals');
 
         // Yaml and Php specific configs
-        if (\in_array($format, ['yml', 'php'])) {
+        if (\in_array($format, ['yml', 'php'], true)) {
             $this->assertEquals('bad', $calls[5][1][0], '->load() registers variables as Twig globals');
             $this->assertEquals(['key' => 'foo'], $calls[5][1][1], '->load() registers variables as Twig globals');
         }

src/Symfony/Component/AssetMapper/ImportMap/ImportMapVersionChecker.php

@@ -120,7 +120,7 @@ public function checkVersions(): array
     public static function convertNpmConstraint(string $versionConstraint): ?string
     {
         // special npm constraint that don't translate to composer
-        if (\in_array($versionConstraint, ['latest', 'next'])
+        if (\in_array($versionConstraint, ['latest', 'next'], true)
             || preg_match('/^(git|http|file):/', $versionConstraint)
             || str_contains($versionConstraint, '/')
         ) {

src/Symfony/Component/AssetMapper/ImportMap/PackageUpdateInfo.php

@@ -29,6 +29,6 @@ public function __construct(
 
     public function hasUpdate(): bool
     {
-        return !\in_array($this->updateType, [self::UPDATE_TYPE_DOWNGRADE, self::UPDATE_TYPE_DOWNGRADE, self::UPDATE_TYPE_UP_TO_DATE]);
+        return !\in_array($this->updateType, [self::UPDATE_TYPE_DOWNGRADE, self::UPDATE_TYPE_DOWNGRADE, self::UPDATE_TYPE_UP_TO_DATE], true);
     }
 }