bump: Infra 1.19 (#229)

* bump: Infra 1.19

* bump: update PHP version to 8.4 in build configuration

* init fixtures update

Author: dkarlovi

.github/workflows/build.yaml

@@ -29,7 +29,7 @@ jobs:
             PHP_VERSION: ${{ matrix.php }}
         strategy:
             matrix:
-                php: [ "8.3" ]
+                php: [ "8.3", "8.4" ]
                 dependencies: [ lowest, highest ]
         steps:
             -
@@ -48,12 +48,12 @@ jobs:
             -
                 name: Composer install
                 env:
-                    PHP_VERSION: 8.3
+                    PHP_VERSION: 8.4
                 run: make composer/install
             -
                 uses: shivammathur/setup-php@v2
                 with:
-                    php-version: 8.3
+                    php-version: 8.4
             -
                 name: Run build
                 working-directory: tests/functional/site
@@ -76,12 +76,12 @@ jobs:
             -
                 name: Composer install
                 env:
-                    PHP_VERSION: 8.3
+                    PHP_VERSION: 8.4
                 run: make composer/install
             -
                 uses: shivammathur/setup-php@v2
                 with:
-                    php-version: 8.3
+                    php-version: 8.4
             -
                 name: Run init
                 working-directory: tests/functional/init

bootstrap.php

@@ -15,7 +15,7 @@
 
 $skipBundles = [];
 if (getenv('YASSG_SKIP_BUNDLES') !== false) {
-    $skipBundles = array_map(static fn (string $name): string => trim($name), explode(',', getenv('YASSG_SKIP_BUNDLES')));
+    $skipBundles = array_map(static fn (string $name): string => mb_trim($name), explode(',', getenv('YASSG_SKIP_BUNDLES')));
 }
 $GLOBALS['YASSG_SKIP_BUNDLES'] = $skipBundles;
 

composer.json

@@ -33,7 +33,7 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^11.4 || ^12.0",
-        "sigwin/infra": "~1.16.0"
+        "sigwin/infra": "^1.19.0"
     },
     "autoload": {
         "psr-4": {

phpstan.baseline.neon

@@ -1,5 +1,11 @@
 parameters:
 	ignoreErrors:
+		-
+			message: '#^Parameter \#2 \$string of function explode expects string, string\|false given\.$#'
+			identifier: argument.type
+			count: 1
+			path: bootstrap.php
+
 		-
 			message: '#^PHPDoc tag @var for variable \$composer has no value type specified in iterable type array\.$#'
 			identifier: missingType.iterableValue
@@ -456,6 +462,12 @@ parameters:
 			count: 2
 			path: src/Bridge/Twig/Extension/ImageExtension.php
 
+		-
+			message: '#^Possibly impure call to function mb_rtrim\(\) in pure method Sigwin\\YASSG\\Bridge\\Twig\\Extension\\ImageExtension\:\:encode\(\)\.$#'
+			identifier: possiblyImpure.functionCall
+			count: 1
+			path: src/Bridge/Twig/Extension/ImageExtension.php
+
 		-
 			message: '#^Result of && is always false\.$#'
 			identifier: booleanAnd.alwaysFalse

psalm.baseline.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="6.8.9@e856423a5dc38d65e56b5792750c557277afe393">
+<files psalm-version="6.12.1@e71404b0465be25cf7f8a631b298c01c5ddd864f">
   <file src="bootstrap.php">
     <PossiblyFalseArgument>
       <code><![CDATA[getenv('YASSG_SKIP_BUNDLES')]]></code>
@@ -461,6 +461,9 @@
       <code><![CDATA[\is_object($item)]]></code>
       <code><![CDATA[\is_string($value)]]></code>
     </DocblockTypeContradiction>
+    <ImpureFunctionCall>
+      <code><![CDATA[mb_rtrim]]></code>
+    </ImpureFunctionCall>
     <InvalidArrayAccess>
       <code><![CDATA[$options['attrs']['class']]]></code>
     </InvalidArrayAccess>

src/AssetQueue.php

@@ -42,7 +42,7 @@ public function add(AssetCopy|AssetFetch $specification): void
     public function flush(?callable $callable = null): array
     {
         foreach ($this->queue as $specification) {
-            $destination = $this->buildDir.'/'.ltrim($specification->destination, '/');
+            $destination = $this->buildDir.'/'.mb_ltrim($specification->destination, '/');
             if (file_exists($destination)) {
                 continue;
             }

src/Bridge/Symfony/Command/GenerateCommand.php

@@ -56,7 +56,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
          * @psalm-suppress UnnecessaryVarAnnotation Psalm's Symfony plugin solves this, but not PHPStan's
          */
         $buildUrl = $input->getArgument('url');
-        $buildUrl = rtrim($buildUrl, '/');
+        $buildUrl = mb_rtrim($buildUrl, '/');
 
         /**
          * @phpstan-var bool $indexFile

src/Bridge/Symfony/Command/InitCommand.php

@@ -59,7 +59,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
          * @var string $namespace
          */
         $namespace = $input->getOption('namespace');
-        $namespace = trim($namespace, '\\');
+        $namespace = mb_trim($namespace, '\\');
 
         $style->section(\sprintf('Namespace: %1$s', $namespace));
 

src/Bridge/Symfony/DependencyInjection/CompilerPass/ConfigureDatabasesCompilerPass.php

@@ -74,7 +74,8 @@ public function process(ContainerBuilder $container): void
                 throw new \LogicException(\sprintf('Unsupported type "%1$s" at "sigwin_yassg.data_sources.%2$s", allowed values: %3$s', $type, $name, implode(', ', array_keys($supportedStorageTypes))));
             }
 
-            $databaseClass = ltrim($database['class'], '\\');
+            /** @var class-string $databaseClass */
+            $databaseClass = mb_ltrim($database['class'], '\\');
 
             $storageDefinition = new Definition($supportedStorageTypes[$type]);
             $storageDefinition

src/Bridge/Symfony/HttpKernel/Fragment/RelativeUrlInlineFragmentRenderer.php

@@ -30,7 +30,7 @@ public function __construct(private InlineFragmentRenderer $fragmentRenderer, pr
     public function render(string|\Symfony\Component\HttpKernel\Controller\ControllerReference $uri, Request $request, array $options = []): \Symfony\Component\HttpFoundation\Response
     {
         if (\is_string($uri)) {
-            $uri = rtrim(str_replace($this->urlGenerator->getContext()->getBaseUrl(), '', $uri), '/');
+            $uri = mb_rtrim(str_replace($this->urlGenerator->getContext()->getBaseUrl(), '', $uri), '/');
         }
 
         return $this->fragmentRenderer->render($uri, $request, $options);