1- re-code parameter encode.

2- add support for multiple result sets.
3- add connect timeout url parameter (default to 1 min).
4- modify default read timeout to be 0 (no timeout).

Author: sijms

README.md

@@ -188,31 +188,36 @@ urlOptions := map[string]string {
     "data integrity": "rejected",
 }
 ```
-* ### Using Unix Socket
+* ### Unix Socket
 you can use this option if server and client on same linux machine by specify the following url option
 ```golang
 urlOptions := map[string]string{
 	// change the value according to your machine 
 	"unix socket": "/usr/tmp/.oracle/sEXTPROC1",
 }
 ```
-* ### Using Timeout
-  * activate global timeout value (default=10 minute and should be updated according to your network speed) to protect against block read/write if no or failed timeout context
-  * timeout value should be numeric string which represent number of seconds that should pass before operation finish or canceled by the driver
+* ### Timeout
+  * activate socket timeout value (default=0 no timeout)
+  * timeout value should be numeric string which represent number of seconds the driver will wait on socket for read/write.
   * to disable this option pass 0 value start from v2.7.15
 ```golang
 urlOptions := map[string]string {
 	"TIMEOUT": "60",
 }
 ```
-* ### Using Proxy user
+* ### Connect Timeout
+  * define timeout for connection (default = 1 minute)
+  * timeout value should be numeric string which represent number of seconds.
+  * to disable this option pass 0 value start from v2.9.0
+
+* ### Proxy user
 ```golang
 urlOptions := map[string]string {
 	"proxy client name": "schema_owner",
 }
 connStr := go_ora.BuildUrl("server", 1521, "service", "proxy_user", "proxy_password", urlOptions)
 ```
-* ### Define DBA Privilege
+* ### DBA Privilege
   * define dba privilege of the connection
   * default value is `NONE`
   * using user `sys` automatically set its value to `SYSDBA`
@@ -221,7 +226,7 @@ urlOptions := map[string]string {
 	"dba privilege" : "sysdba", // other values "SYSOPER"
 }
 ```
-* ### Define Lob Fetching Mode
+* ### Lob Fetching Mode
   * this option define how lob data will be loaded
   * default value is `pre` or `inline` means lob data is send inline with other values
   * other value is `post` or `stream` means lob data will be loaded after finish loading other value through a separate network call
@@ -230,7 +235,7 @@ urlOptions := map[string]string {
 	"lob fetch": "stream",
 }
 ```
-* ### Define Client Charset
+* ### Client Charset
   * this option will allow controlling string encoding and decoding at client level
   * so using this option you can define a charset for the client that is different from the server
   * client charset will work in the following situation
@@ -698,6 +703,11 @@ db, err := sql.Open("oracle", "")
     // error handling
   }
   ```
+  
+* ### Multiple ResultSets
+  * the driver support multiple resultsets start from v2.9.0
+  * example code can be reviewed [here](https://github.com/sijms/go-ora/blob/master/examples/multi_resultsets/main.go)
+
 [//]: # (### Go and Oracle type mapping + special types)
 
 [//]: # ()
@@ -724,6 +734,13 @@ go_ora.RegisterConfig(config)
 db, err := sql.Open("oracle", "")
 ```
 
+### version 2.9.0
+* modify parameter encoding to fix support for Valuer interface issue
+* add connect timeout url parameter (default=60 seconds)
+* change default timeout for socket to 0 (no-timeout)
+* add support for multiple result sets
+* fix issue related to using RefCursor without opening
+
 ### version 2.8.12
 * add 2 functions
   * ParseConfig

examples/arrays/main.go

@@ -65,7 +65,7 @@ func insert(db *sql.DB) error {
 			args[x].Date.Valid = false
 		}
 	}
-	_, err := db.Exec(sqlText, args)
+	_, err := db.Exec(sqlText, go_ora.NewBatch(args))
 	if err != nil {
 		return err
 	}
@@ -223,7 +223,7 @@ func main() {
 	)
 	flag.StringVar(&server, "server", "", "Server's URL, oracle://user:pass@server/service_name")
 	flag.Parse()
-	server = os.Getenv("LOCAL_DSN")
+	server = os.Getenv("DSN")
 	connStr := os.ExpandEnv(server)
 	if connStr == "" {
 		fmt.Println("Missing -server option")

examples/bulk_copy/main.go

@@ -113,12 +113,12 @@ func bulkInsert3(db *sql.DB, rowNum int) error {
 
 		}
 	}
-	_, err := db.Exec(sqlText, sql.Named("id", id),
-		sql.Named("name", name),
-		sql.Named("val", val),
-		sql.Named("dat", date),
-		sql.Named("major", major),
-		sql.Named("data", data))
+	_, err := db.Exec(sqlText, sql.Named("id", go_ora.NewBatch(id)),
+		sql.Named("name", go_ora.NewBatch(name)),
+		sql.Named("val", go_ora.NewBatch(val)),
+		sql.Named("dat", go_ora.NewBatch(date)),
+		sql.Named("major", go_ora.NewBatch(major)),
+		sql.Named("data", go_ora.NewBatch(data)))
 	if err != nil {
 		return err
 	}
@@ -162,12 +162,12 @@ func bulkInsert2(db *sql.DB, rowNum int) error {
 
 		}
 	}
-	_, err := db.Exec(sqlText, sql.Named("id", id),
-		sql.Named("name", name),
-		sql.Named("val", val),
-		sql.Named("dat", date),
-		sql.Named("major", major),
-		sql.Named("data", data))
+	_, err := db.Exec(sqlText, sql.Named("id", go_ora.NewBatch(id)),
+		sql.Named("name", go_ora.NewBatch(name)),
+		sql.Named("val", go_ora.NewBatch(val)),
+		sql.Named("dat", go_ora.NewBatch(date)),
+		sql.Named("major", go_ora.NewBatch(major)),
+		sql.Named("data", go_ora.NewBatch(data)))
 	if err != nil {
 		return err
 	}
@@ -274,32 +274,32 @@ func main() {
 		return
 	}
 
-	//err = createTable(conn)
-	//if err != nil {
-	//	fmt.Println("Can't create table: ", err)
-	//	return
-	//}
+	err = createTable(conn)
+	if err != nil {
+		fmt.Println("Can't create table: ", err)
+		return
+	}
 
-	//defer func() {
-	//	err = dropTable(conn)
-	//	if err != nil {
-	//		fmt.Println("Can't drop table: ", err)
-	//	}
-	//}()
+	defer func() {
+		err = dropTable(conn)
+		if err != nil {
+			fmt.Println("Can't drop table: ", err)
+		}
+	}()
 
 	//err = insertData(conn)
 	//if err != nil {
 	//	fmt.Println("Can't insert data: ", err)
 	//	return
 	//}
 	//
-	err = deleteData(conn)
-	if err != nil {
-		fmt.Println("Can't delete data: ", err)
-		return
-	}
+	//err = deleteData(conn)
+	//if err != nil {
+	//	fmt.Println("Can't delete data: ", err)
+	//	return
+	//}
 
-	err = bulkInsert3(conn, 10)
+	err = bulkInsert3(conn, 100000)
 	if err != nil {
 		fmt.Println("Can't insert: ", err)
 		return