refactor if logic to reduce the number of negatives

briskt · briskt · commit b65bac365aa3 · 2025-04-09T07:34:04.000+08:00
diff --git a/upgrader.go b/upgrader.go
@@ -244,7 +244,7 @@ func (u *Upgrader) UpgradeCluster() error {
 		return err
 	}
 
-	if !oldImageFound && !isNewer && !u.forceReplacement {
+	if !(oldImageFound || isNewer || u.forceReplacement) {
 		u.logger.Println("Upgrade not needed, cluster is already running the latest AMI")
 		return u.terminateOrphanedInstances(asgName)
 	}

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ func (u *Upgrader) UpgradeCluster() error {`
`244`	`244`	`return err`
`245`	`245`	`}`
`246`	`246`
`247`		`- if !oldImageFound && !isNewer && !u.forceReplacement {`
	`247`	`+ if !(oldImageFound \|\| isNewer \|\| u.forceReplacement) {`
`248`	`248`	`u.logger.Println("Upgrade not needed, cluster is already running the latest AMI")`
`249`	`249`	`return u.terminateOrphanedInstances(asgName)`
`250`	`250`	`}`