superfluous code

Author: Billy Clark

themes/material/core/loginuserpass.php

@@ -38,7 +38,7 @@ function onRecaptchaLoad() {
         <?php include __DIR__ . '/../common-announcement.php' ?>
 
 
-        <form method="POST" action="<?= htmlentities($_SERVER['PHP_SELF']) ?>">
+        <form method="POST">
             <input type="hidden" name="AuthState"
                    value="<?= htmlentities($this->data['stateparams']['AuthState']  ?? null) ?>" />
             <?php

themes/material/default/selectidp-links.php

@@ -37,8 +37,7 @@ function clickedAnyway(idpName) {
     <main class="mdl-layout__content">
         <?php include __DIR__ . '/../common-announcement.php' ?>
 
-        <form action="<?= htmlentities($_SERVER['PHP_SELF']) ?>"
-              layout-children="row" child-spacing="space-around">
+        <form layout-children="row" child-spacing="space-around">
             <input type="hidden" name="entityID"
                    value="<?= htmlentities($this->data['entityID'] ?? null) ?>" />
             <input type="hidden" name="return"

themes/material/expirychecker/about2expire.php

@@ -16,8 +16,7 @@
     </header>
 <!--TODO: do we need ?? null on these data[] retrievals as done in other pages? Test what happens when the key is altered to a nonexistent name -->
     <main class="mdl-layout__content" layout-children="column">
-<!--        TODO: since this is just a GET back to itself, I don't think action is needed at all...need to test in other browsers to make sure though. -->
-        <form action="<?= htmlentities($this->data['formTarget']); ?>" layout-children="column">
+        <form layout-children="column">
             <?php
             foreach ($this->data['formData'] as $name => $value) {
             ?>

themes/material/expirychecker/expired.php

@@ -16,8 +16,7 @@
     </header>
 <!--TODO: do we need ?? null on these data[] retrievals as done in other pages? Test what happens when the key is altered to a nonexistent name -->
     <main class="mdl-layout__content" layout-children="column">
-<!--        TODO: since this is just a GET back to itself, I don't think action is needed at all...need to test in other browsers to make sure though. -->
-        <form action="<?= htmlentities($this->data['formTarget']); ?>" layout-children="column">
+        <form layout-children="column">
             <?php
             foreach ($this->data['formData'] as $name => $value) {
             ?>