module-mfa became more consistent in its use of form methods.

Author: Billy Clark

themes/material/mfa/must-set-up-mfa.php

@@ -15,15 +15,7 @@
         </div>
     </header>
     <main class="mdl-layout__content" layout-children="column">
-        <form layout-children="column"> <!-- TODO: change method to POST once implemented -->
-            <?php
-            foreach ($this->data['formData'] as $name => $value) {
-            ?>
-            <input type="hidden" name="<?= htmlentities($name); ?>"
-                   value="<?= htmlentities($value); ?>"/>
-            <?php
-            }
-            ?>
+        <form layout-children="column" method="post">
             <div class="mdl-card mdl-shadow--8dp">
                 <div class="mdl-card__media white-bg margin" layout-children="column">
                     <img src="mfa-shield.svg" alt="<?= $this->t('{material:mfa:shield_icon}') ?>">

themes/material/mfa/nag-for-mfa.php

@@ -15,15 +15,7 @@
         </div>
     </header>
     <main class="mdl-layout__content" layout-children="column">
-        <form layout-children="column"> <!-- TODO: change method to POST once implemented -->
-            <?php
-            foreach ($this->data['formData'] as $name => $value) {
-            ?>
-            <input type="hidden" name="<?= htmlentities($name); ?>"
-                   value="<?= htmlentities($value); ?>"/>
-            <?php
-            }
-            ?>
+        <form layout-children="column" method="post">
             <div class="mdl-card mdl-shadow--8dp">
                 <div class="mdl-card__media white-bg margin" layout-children="column">
                     <img src="mfa-shield.svg" alt="<?= $this->t('{material:mfa:shield_icon}') ?>">

themes/material/mfa/other_mfas.php

@@ -7,7 +7,7 @@
 <ul class="mdl-menu mdl-js-menu mdl-menu--top-left" data-mdl-for="others">
     <?php
     $mfaOptions = $this->data['mfaOptions'];
-    $currentMfaId = $this->data['formData']['mfaId'];
+    $currentMfaId = filter_input(INPUT_GET, 'mfaId');
 
     function excludeSelf($others, $selfId) {
         return array_filter($others, function($option) use ($selfId) {

themes/material/mfa/prompt-for-mfa-backupcode.php

@@ -15,15 +15,7 @@
         </div>
     </header>
     <main class="mdl-layout__content" layout-children="column">
-        <form layout-children="column" method="POST">
-            <?php
-            foreach ($this->data['formData'] as $name => $value) {
-            ?>
-            <input type="hidden" name="<?= htmlentities($name); ?>"
-                   value="<?= htmlentities($value); ?>"/>
-            <?php
-            }
-            ?>
+        <form layout-children="column" method="post">
             <div class="mdl-card mdl-shadow--8dp">
                 <div class="mdl-card__media white-bg margin" layout-children="column">
                     <img src="mfa-backupcode.svg"
@@ -49,6 +41,7 @@
                         </label>
                         <input name="mfaSubmission" class="mdl-textfield__input" autofocus
                                id="mfaSubmission"/>
+<!--                        TODO: don't remember codes here since they are one-time use anyway-->
                     </div>
                 </div>
 

themes/material/mfa/prompt-for-mfa-totp.php

@@ -15,15 +15,7 @@
         </div>
     </header>
     <main class="mdl-layout__content" layout-children="column">
-        <form layout-children="column" method="POST">
-            <?php
-            foreach ($this->data['formData'] as $name => $value) {
-            ?>
-            <input type="hidden" name="<?= htmlentities($name); ?>"
-                   value="<?= htmlentities($value); ?>"/>
-            <?php
-            }
-            ?>
+        <form layout-children="column" method="post">
             <div class="mdl-card mdl-shadow--8dp">
                 <div class="mdl-card__media white-bg margin" layout-children="column">
                     <img src="mfa-totp.svg" alt="<?= $this->t('{material:mfa:totp_icon}') ?>">

themes/material/mfa/prompt-for-mfa-u2f.php

@@ -76,15 +76,7 @@ function createHiddenInput(name) {
     </header>
 
     <main class="mdl-layout__content" layout-children="column">
-        <form layout-children="column" method="POST">
-            <?php
-            foreach ($this->data['formData'] as $name => $value) {
-            ?>
-            <input type="hidden" name="<?= htmlentities($name); ?>"
-                   value="<?= htmlentities($value); ?>"/>
-            <?php
-            }
-            ?>
+        <form layout-children="column" method="post">
             <div class="mdl-card mdl-shadow--8dp">
                 <div class="mdl-card__media white-bg margin" layout-children="column">
                     <img src="mfa-u2f.png" alt="<?= $this->t('{material:mfa:u2f_icon}') ?>">