code review feedback

Author: Billy Clark

Makefile

@@ -1,4 +1,5 @@
 start:
+	docker-compose pull
 	docker-compose up -d
 
 errors:

README.md

@@ -116,7 +116,7 @@ If configured, an alert will be shown to the user filled with the content of tha
 4. Click **Test configured authentication sources**
 5. Click **hub-discovery**
 6. Click **idp2**
-7. Login as an "about to expire" user: `username=`**near_future** `password=`**b**
+7. Login as an "about to expire" user: `username=`**near_future** `password=`**a**
 8. Click **Later**
 9. Click **Logout**
 
@@ -127,7 +127,7 @@ If configured, an alert will be shown to the user filled with the content of tha
 4. Click **Test configured authentication sources**
 5. Click **hub-discovery**
 6. Click **idp2**
-7. Login as an "expired" user: `username=`**already_past** `password=`**c**
+7. Login as an "expired" user: `username=`**already_past** `password=`**a**
 
 ### Multi-factor authentication (MFA) functionality
 #### Nag about missing MFA setup

development/idp2/authsources.php

@@ -14,7 +14,7 @@
                 gmdate('YmdHis\Z', strtotime('+6 months')), // Distant future
             ],
         ],
-        'near_future:b' => [
+        'near_future:a' => [
             'eduPersonPrincipalName' => ['[email protected]'],
             'eduPersonTargetID' => ['22222222-2222-2222-2222-222222222222'],
             'sn' => ['Future'],
@@ -26,7 +26,7 @@
                 gmdate('YmdHis\Z', strtotime('+1 day')), // Very soon
             ],
         ],
-        'already_past:c' => [
+        'already_past:a' => [
             'eduPersonPrincipalName' => ['[email protected]'],
             'eduPersonTargetID' => ['33333333-3333-3333-3333-333333333333'],
             'sn' => ['Past'],

development/idp2/saml20-idp-hosted.php

@@ -11,7 +11,7 @@
             'class' => 'expirychecker:ExpiryDate',
             'accountNameAttr' => 'cn',
             'expiryDateAttr' => 'schacExpiryDate',
-            'changePwdUrl' => Env::get('CHANGE_PWD_URL'),
+            'passwordChangeUrl' => Env::get('PASSWORD_CHANGE_URL'),
             'warnDaysBefore' => 14,
             'dateFormat' => 'Y-m-d',
             'loggerClass' => Psr3SamlLogger::class,