Incorporated PR feedback

Author: Billy Clark

dictionaries/login.definition.json

@@ -36,10 +36,10 @@
 		"ko": "로그인"
 	},
 	"forgot": {
-		"en": "Forgot your password? Reset it now",
-		"es": "¿Olvidaste tu contraseña? Restablecer ahora",
-		"fr": "Mot de passe oublié? Réinitialisez-le maintenant",
-		"ko": "비밀번호를 잊어 버렸습니까? 지금 다시 설정하십시오"
+		"en": "Forgot password?",
+		"es": "¿Se te olvidó tu contraseña?",
+		"fr": "Mot de passe oublié?",
+		"ko": "비밀번호를 잊으 셨나요?"
 	},
 	"logo": {
 		"en": "{idpName} logo",

themes/material/core/loginuserpass.php

@@ -46,14 +46,14 @@ function onRecaptchaLoad() {
         <?php include __DIR__ . '/../common-announcement.php' ?>
 
         <div class="mdl-card mdl-shadow--8dp">
-            <div class="mdl-card__media white-bg margin">
-
+            <div class="mdl-card__media white-bg margin" layout-children="column">
+<!--                TODO: update to /logo.png-->
                 <img src="https://static.gtis.guru/idp-logo/sil-logo.png"
                      alt="<?= $this->t('{material:login:logo}', ['{idpName}' => $idpName]) ?>">
             </div>
 
 
-            <div class="mdl-card__title">
+            <div class="mdl-card__title center">
                 <h1 class="mdl-card__title-text">
                     <?= $this->t('{material:login:header}', ['{idpName}' => $idpName]) ?>
                 </h1>
@@ -100,19 +100,21 @@ function onRecaptchaLoad() {
 
             <div class="mdl-card__actions" layout-children="row">
                 <?php
+                $forgotPasswordUrl = "asfsgf";
                 if (! empty($forgotPasswordUrl)) {
-                    ?>
-                    <a href="<?= htmlentities($forgotPasswordUrl) ?>" target="_blank"
-                       class="mdl-typography--caption margin">
-                        <?= $this->t('{material:login:forgot}') ?>
-                    </a>
-                    <?php
+                ?>
+                <a href="<?= htmlentities($forgotPasswordUrl) ?>" target="_blank"
+                   class="mdl-button mdl-button--colored mdl-typography--caption">
+                    <?= $this->t('{material:login:forgot}') ?>
+                </a>
+                <?php
                 }
                 ?>
-
+<!--TODO: look at filling viewport on phones.-->
                 <span flex></span>
 
-                <button class="mdl-button mdl-button--colored" form="loginform">
+                <button type="submit" form="loginform"
+                        class="mdl-button mdl-button--colored mdl-button--raised">
                     <?= $this->t('{material:login:button_login}') ?>
                 </button>
             </div>

www/styles.2.1.0.css

@@ -108,8 +108,7 @@ form p.error {
   border-radius: 0.33em;
   padding: 1em;
 
-  /*
-     had to center manually instead of using flex due to ie11 bug that
+  /* had to center manually instead of using flex due to ie11 bug that
      was causing idp cards not to wrap when parent container was centered
    */
   margin-left: auto;
@@ -123,12 +122,28 @@ form p.error {
 /* The font-size in the mdl-textfield was overriding the one in
    caption since it was defined later in the CSS but the font-size from
    caption is what was needed here so more specificity required to override
-   it back
-*/
+   it back */
 .mdl-textfield.mdl-typography--caption {
   font-size: 12px
 }
 
+/* special case where we want a button for all it's built-in characteristics, e.g., primary color,
+   but also want to set the text apart a bit. */
+.mdl-button.mdl-typography--caption {
+  text-transform: none;
+  font-size: 12px
+}
+
+/* didn't feel like the padding was enough out of the box */
+.mdl-card__actions {
+  padding: 1em;
+}
+
+/* needed ability to center text in these card titles at times */
+.mdl-card__title.center {
+  justify-content: center;
+}
+
 [flex] {
   flex: 1;
 }