Skip to content

Commit 675a4db

Browse files
committed
better docs
1 parent c794bd4 commit 675a4db

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

examples/minimal/build.zig

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,10 @@ pub fn build(b: *std.Build) void {
3434
// Add Java files
3535
// - If you have 'android:hasCode="false"' in your AndroidManifest.xml then no Java files are required
3636
// see: https://developer.android.com/ndk/samples/sample_na
37+
//
38+
// WARNING: If you do not provide Java files AND android:hasCode="false" isn't explicitly set, then you may get the following error on "adb install"
39+
// Scanning Failed.: Package /data/app/base.apk code is missing]
40+
//
3741
// apk.addJavaSourceFile(.{ .file = b.path("android/src/X.java") });
3842
break :blk apk;
3943
};

src/androidbuild/apk.zig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ fn doInstallApk(apk: *Apk) std.mem.Allocator.Error!*Step.InstallFile {
207207
// This validation rule has been removed because if you have `android:hasCode="false"` in your AndroidManifest.xml file
208208
// then you can have no Java files.
209209
//
210-
// If you do not provide Java files AND hasCode=false isn't set, then you may get the following error on "adb install"
210+
// If you do not provide Java files AND android:hasCode="false" isn't set, then you may get the following error on "adb install"
211211
// - Scanning Failed.: Package /data/app/base.apk code is missing]
212212
//
213213
// Ideally we may want to do something where we can utilize "aapt2 dump X" to determine if "hasCode" is set and if it isn't, throw

0 commit comments

Comments
 (0)