[xml] remove unreachable TBufferXML::Xml[Read|Write]Block()

The documentation of XmlWriteBlock() says "This data can be produced
only by direct call of TBuffer::WriteBuf() functions.".
The WriteBuf() abstract method is implemented in the TBufferText
parent class and emits an Error().

Author: jblomer

io/xml/inc/TBufferXML.h

@@ -228,10 +228,8 @@ class TBufferXML final : public TBufferText, public TXMLSetup {
    void SetCompressionSettings(Int_t settings = ROOT::RCompressionSetting::EDefaults::kUseCompiledDefault);
    void SetXML(TXMLEngine *xml) { fXML = xml; }
 
-   void XmlWriteBlock(XMLNodePointer_t node);
    XMLNodePointer_t XmlWriteAny(const void *obj, const TClass *cl);
 
-   void XmlReadBlock(XMLNodePointer_t node);
    void *XmlReadAny(XMLNodePointer_t node, void *obj, TClass **cl);
 
    TXMLStackObj *PushStack(XMLNodePointer_t current, Bool_t simple = kFALSE);

io/xml/src/TBufferXML.cxx

@@ -383,138 +383,6 @@ void TBufferXML::SetCompressionSettings(Int_t settings)
    fCompressLevel = settings;
 }
 
-////////////////////////////////////////////////////////////////////////////////
-/// Write binary data block from buffer to xml.
-/// This data can be produced only by direct call of TBuffer::WriteBuf() functions.
-
-void TBufferXML::XmlWriteBlock(XMLNodePointer_t node)
-{
-   if (!node || (Length() == 0))
-      return;
-
-   const char *src = Buffer();
-   int srcSize = Length();
-
-   char *fZipBuffer = nullptr;
-
-   Int_t compressionLevel = GetCompressionLevel();
-   ROOT::RCompressionSetting::EAlgorithm::EValues compressionAlgorithm =
-      static_cast<ROOT::RCompressionSetting::EAlgorithm::EValues>(GetCompressionAlgorithm());
-
-   if ((Length() > 512) && (compressionLevel > 0)) {
-      int zipBufferSize = Length();
-      fZipBuffer = new char[zipBufferSize + 9];
-      int dataSize = Length();
-      int compressedSize = 0;
-      R__zipMultipleAlgorithm(compressionLevel, &dataSize, Buffer(), &zipBufferSize, fZipBuffer, &compressedSize,
-                              compressionAlgorithm);
-      if (compressedSize > 0) {
-         src = fZipBuffer;
-         srcSize = compressedSize;
-      } else {
-         delete[] fZipBuffer;
-         fZipBuffer = nullptr;
-      }
-   }
-
-   TString res;
-   constexpr std::size_t sbufSize = 500;
-   char sbuf[sbufSize];
-   int block = 0;
-   char *tgt = sbuf;
-   int srcCnt = 0;
-
-   while (srcCnt++ < srcSize) {
-      tgt += snprintf(tgt, sbufSize - (tgt - sbuf), " %02x", (unsigned char)*src);
-      src++;
-      if (block++ == 100) {
-         res += sbuf;
-         block = 0;
-         tgt = sbuf;
-      }
-   }
-
-   if (block > 0)
-      res += sbuf;
-
-   XMLNodePointer_t blocknode = fXML->NewChild(node, nullptr, xmlio::XmlBlock, res);
-   fXML->NewIntAttr(blocknode, xmlio::Size, Length());
-
-   if (fZipBuffer) {
-      fXML->NewIntAttr(blocknode, xmlio::Zip, srcSize);
-      delete[] fZipBuffer;
-   }
-}
-
-////////////////////////////////////////////////////////////////////////////////
-/// Read binary block of data from xml.
-
-void TBufferXML::XmlReadBlock(XMLNodePointer_t blocknode)
-{
-   if (!blocknode)
-      return;
-
-   Int_t blockSize = fXML->GetIntAttr(blocknode, xmlio::Size);
-   Bool_t blockCompressed = fXML->HasAttr(blocknode, xmlio::Zip);
-   char *fUnzipBuffer = nullptr;
-
-   if (gDebug > 2)
-      Info("XmlReadBlock", "Block size = %d, Length = %d, Compressed = %d", blockSize, Length(), blockCompressed);
-
-   if (blockSize > BufferSize())
-      Expand(blockSize);
-
-   char *tgt = Buffer();
-   Int_t readSize = blockSize;
-
-   TString content = fXML->GetNodeContent(blocknode);
-
-   if (blockCompressed) {
-      Int_t zipSize = fXML->GetIntAttr(blocknode, xmlio::Zip);
-      fUnzipBuffer = new char[zipSize];
-
-      tgt = fUnzipBuffer;
-      readSize = zipSize;
-   }
-
-   char *ptr = (char *)content.Data();
-
-   if (gDebug > 3)
-      Info("XmlReadBlock", "Content %s", ptr);
-
-   for (int i = 0; i < readSize; i++) {
-      while ((*ptr < 48) || ((*ptr > 57) && (*ptr < 97)) || (*ptr > 102))
-         ptr++;
-
-      int b_hi = (*ptr > 57) ? *ptr - 87 : *ptr - 48;
-      ptr++;
-      int b_lo = (*ptr > 57) ? *ptr - 87 : *ptr - 48;
-      ptr++;
-
-      *tgt = b_hi * 16 + b_lo;
-      tgt++;
-
-      if (gDebug > 4)
-         Info("XmlReadBlock", "    Buf[%d] = %d", i, b_hi * 16 + b_lo);
-   }
-
-   if (fUnzipBuffer) {
-
-      int srcsize(0), tgtsize(0), unzipRes(0);
-      int status = R__unzip_header(&srcsize, (UChar_t *)fUnzipBuffer, &tgtsize);
-
-      if (status == 0)
-         R__unzip(&readSize, (unsigned char *)fUnzipBuffer, &blockSize, (unsigned char *)Buffer(), &unzipRes);
-
-      if (status != 0 || unzipRes != blockSize)
-         Error("XmlReadBlock", "Decompression error %d", unzipRes);
-      else if (gDebug > 2)
-         Info("XmlReadBlock", "Unzip ok");
-
-      delete[] fUnzipBuffer;
-   }
-}
-
 ////////////////////////////////////////////////////////////////////////////////
 /// Add "ptr" attribute to node, if ptr is null or
 /// if ptr is pointer on object, which is already saved in buffer

io/xml/src/TKeyXML.cxx

@@ -190,8 +190,6 @@ void TKeyXML::StoreObject(const void *obj, const TClass *cl, Bool_t check_tobj)
    if (node)
       xml->AddChildFirst(fKeyNode, node);
 
-   buffer.XmlWriteBlock(fKeyNode);
-
    if (cl)
       fClassName = cl->GetName();
 }
@@ -352,7 +350,6 @@ void *TKeyXML::XmlReadAny(void *obj, const TClass *expectedClass)
          break;
       xml->ShiftToNext(blocknode);
    }
-   buffer.XmlReadBlock(blocknode);
 
    XMLNodePointer_t objnode = xml->GetChild(fKeyNode);
    xml->SkipEmpty(objnode);