Skip to content

Commit 3bee4a1

Browse files
author
Garrett Jones
committed
Add a temporary hack for customization modal
1 parent a33f054 commit 3bee4a1

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

components/language-chooser/svelte/language-chooser-svelte/src/lib/CustomizationModal.svelte

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,10 @@
99
1010
let {
1111
languageChooser,
12+
_languageChooser,
1213
}: {
1314
languageChooser: SvelteViewModel<LanguageChooserViewModel>;
15+
_languageChooser: LanguageChooserViewModel;
1416
} = $props();
1517
1618
let isCreatingUnlisted = $state(false);
@@ -36,7 +38,7 @@
3638
let onOk = $state(() => {});
3739
3840
function submitUnlisted(name: string, region: IRegion) {
39-
languageChooser.submitUnlistedLanguageModal({ name, region });
41+
_languageChooser.submitUnlistedLanguageModal({ name, region });
4042
modal.close();
4143
}
4244
@@ -45,7 +47,7 @@
4547
region?: IRegion,
4648
dialect?: string
4749
) {
48-
languageChooser.submitCustomizeLangaugeModal({ script, region, dialect });
50+
_languageChooser.submitCustomizeLangaugeModal({ script, region, dialect });
4951
modal.close();
5052
}
5153
</script>

components/language-chooser/svelte/language-chooser-svelte/src/lib/LanguageChooser.svelte

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,10 @@
1818
onOk: (orthography: IOrthography, languageTag?: string) => void;
1919
} = $props();
2020
21-
const viewModel = useViewModel(new LanguageChooserViewModel());
21+
// HACK: Accessing the original _viewModel gets around bugs in useViewModel.
22+
// useViewModel is broken and needs redesign.
23+
const _viewModel = new LanguageChooserViewModel();
24+
const viewModel = useViewModel(_viewModel);
2225
2326
let orthography: IOrthography = $derived({
2427
language: viewModel.selectedLanguage,
@@ -73,11 +76,7 @@
7376
>
7477
<button
7578
class="card-body text-left"
76-
onclick={() => {
77-
console.log(viewModel.onCustomizeButtonClicked);
78-
console.log(viewModel.displayName);
79-
viewModel.onCustomizeButtonClicked();
80-
}}
79+
onclick={() => _viewModel.onCustomizeButtonClicked()}
8180
>
8281
<p class="card-title uppercase">
8382
{#if viewModel.selectedLanguage}
@@ -128,4 +127,4 @@
128127
</div>
129128
</div>
130129

131-
<CustomizationModal languageChooser={viewModel} />
130+
<CustomizationModal languageChooser={viewModel} _languageChooser={_viewModel} />

0 commit comments

Comments
 (0)