Skip to content

Commit 5995465

Browse files
committed
fix: BL-14315 unwanted scrollbar in customization dialog
1 parent 1042a1e commit 5995465

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

components/language-chooser/react/language-chooser-react-mui/e2e/customizationDialog.e2e.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ async function enterScript(customizationDialog, scriptName) {
3535
.locator("#customize-script-field-wrapper")
3636
.getByLabel("Open")
3737
.click();
38-
await customizationDialog.getByRole("option", { name: scriptName }).click();
38+
await page.getByRole("option", { name: scriptName }).click();
3939
}
4040

4141
function regionFieldLocator(customizationDialog) {
@@ -48,7 +48,7 @@ async function enterRegion(customizationDialog, regionName) {
4848
.locator("#customize-region-field-wrapper")
4949
.getByLabel("Open")
5050
.click();
51-
await customizationDialog.getByRole("option", { name: regionName }).click();
51+
await page.getByRole("option", { name: regionName }).click();
5252
}
5353

5454
function variantFieldLocator(customizationDialog) {
@@ -290,7 +290,7 @@ test.describe("Customization button and dialog", () => {
290290
.locator("#customize-script-field-wrapper")
291291
.getByLabel("Open")
292292
.click();
293-
await customizationDialog
293+
await page
294294
.getByRole("option", { name: "Arabic" })
295295
.filter({ hasNotText: "Arabic (Nastaliq variant)" })
296296
.click();

components/language-chooser/react/language-chooser-react-mui/src/CustomizeLanguageDialog.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,6 @@ export const CustomizeLanguageDialog: React.FunctionComponent<{
216216
) => {
217217
setDialogSelectedScript(newValue || EMPTY_COMBOBOX_VALUE);
218218
}}
219-
disablePortal
220219
options={getAllScriptOptions()}
221220
renderInput={(params) => <TextField {...params} />}
222221
size={"small"}
@@ -239,7 +238,6 @@ export const CustomizeLanguageDialog: React.FunctionComponent<{
239238
) => {
240239
setDialogSelectedRegion(newValue || EMPTY_COMBOBOX_VALUE);
241240
}}
242-
disablePortal
243241
options={getAllRegionOptions()}
244242
renderInput={(params) => <TextField {...params} />}
245243
size={"small"}

0 commit comments

Comments
 (0)