Skip to content

Commit 56de6f2

Browse files
authored
Merge pull request #78 from sillsdev/add-win64-support-in-makewixfordirtree
Added MakeWixForDirTree.SetWin64
2 parents 411316a + 2d1d6ef commit 56de6f2

File tree

9 files changed

+16
-8
lines changed

9 files changed

+16
-8
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
1919
### Added
2020

2121
- [SIL.BuildTasks] Added FileUpdate.FileLocalePattern (optional param) to infer a locale (e.g., for a localized release notes file) to use when doing date insertion involving month names or abbreviations.
22+
- [SIL.BuildTasks] Added MakeWixForDirTree.SetWin64 (optional Boolean param) to set the Win64 attribute to "yes" when building wxs file to be used in a 64-bit installer.
2223

2324
### Changed
2425

RecreateGuidDatabase/RecreateGuidDatabase.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
<ItemGroup>
1010
<PackageReference Include="Markdig.Signed" Version="0.41.1" />
11-
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="17.14.8" />
11+
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="17.14.28" />
1212
<PackageReference Include="SIL.ReleaseTasks.Dogfood" Version="[2.3.3-*,)" PrivateAssets="All" />
1313
</ItemGroup>
1414
</Project>

SIL.BuildTasks.AWS/SIL.BuildTasks.AWS.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<PrivateAssets>All</PrivateAssets>
1313
</PackageReference>
1414
<PackageReference Include="Markdig.Signed" Version="0.41.1" />
15-
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="17.14.8" />
15+
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="17.14.28" />
1616
<PackageReference Include="SIL.ReleaseTasks.Dogfood" Version="[2.3.3-*,)" PrivateAssets="All" />
1717
</ItemGroup>
1818
<!-- Collect all dependencies and include them in the package itself, next to the Task assembly. -->

SIL.BuildTasks.Tests/SIL.BuildTasks.Tests.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
<PackageReference Include="JetBrains.Annotations" Version="2024.3.0">
1515
<PrivateAssets>All</PrivateAssets>
1616
</PackageReference>
17-
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="17.14.8" />
18-
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="17.14.8" />
17+
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="17.14.28" />
18+
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="17.14.28" />
1919
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.0" />
2020
<PackageReference Include="Moq" Version="4.20.72" />
2121
<PackageReference Include="NUnit" Version="4.3.2" />

SIL.BuildTasks/MakeWixForDirTree/MakeWixForDirTree.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,11 @@ public string IgnoreRegExPattern
8686
/// </summary>
8787
public bool CheckOnly { get; set; }
8888

89+
/// <summary>
90+
/// Whether to add Win64="yes" (for use in 64-bit installer).
91+
/// </summary>
92+
public bool SetWin64 { get; set; }
93+
8994
/// <summary>
9095
/// Directory where the installer source (.wixproj) is located.
9196
/// If provided, is used to determine relative path of the components
@@ -391,6 +396,8 @@ private void ProcessFile(XmlNode parent, string path, XmlDocument doc, IdToGuidD
391396
_filesChanged = true; // this file is new
392397
else
393398
elemComp.SetAttribute("Guid", guid.ToUpper());
399+
if (SetWin64)
400+
elemComp.SetAttribute("Win64", "yes");
394401
parent.AppendChild(elemComp);
395402

396403
var elemFile = doc.CreateElement("File", Xmlns);

SIL.BuildTasks/SIL.BuildTasks.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<PrivateAssets>All</PrivateAssets>
1212
</PackageReference>
1313
<PackageReference Include="Markdig.Signed" Version="0.41.1" />
14-
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="17.14.8" />
14+
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="17.14.28" />
1515
<PackageReference Include="SIL.Core" Version="7.0.0" />
1616
<PackageReference Include="SIL.ReleaseTasks.Dogfood" Version="[2.3.3-*,)" PrivateAssets="All" />
1717
</ItemGroup>

SIL.ReleaseTasks.Dogfood/SIL.ReleaseTasks.Dogfood.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<PrivateAssets>All</PrivateAssets>
1919
</PackageReference>
2020
<PackageReference Include="Markdig.Signed" Version="0.41.1" />
21-
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="17.14.8" />
21+
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="17.14.28" />
2222
</ItemGroup>
2323
<Import Project="..\SIL.ReleaseTasks\SIL.ReleaseTasks.Common.inc" />
2424
</Project>

SIL.ReleaseTasks.Tests/SIL.ReleaseTasks.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
</ItemGroup>
1212
<ItemGroup>
1313
<PackageReference Include="Markdig.Signed" Version="0.41.1" />
14-
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="17.14.8" />
14+
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="17.14.28" />
1515
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.0" />
1616
<PackageReference Include="NUnit" Version="4.3.2" />
1717
<PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />

SIL.ReleaseTasks/SIL.ReleaseTasks.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<PrivateAssets>All</PrivateAssets>
1212
</PackageReference>
1313
<PackageReference Include="Markdig.Signed" Version="0.41.1" />
14-
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="17.14.8" />
14+
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="17.14.28" />
1515
<PackageReference Include="SIL.ReleaseTasks.Dogfood" Version="[2.3.3-*,)" PrivateAssets="All" />
1616
</ItemGroup>
1717
<Import Project="SIL.ReleaseTasks.Common.inc" />

0 commit comments

Comments
 (0)