Use True/False instead of yes/no string

imnasnainaec · imnasnainaec · commit a3cc1f5b177c · 2026-01-23T17:36:09.000-05:00
diff --git a/deploy/ansible/ansible.cfg b/deploy/ansible/ansible.cfg
@@ -31,8 +31,8 @@
 # the remote system.
 #
 # smart - gather by default, but don't regather if already gathered
-# implicit - gather by default, turn off with gather_facts: no
-# explicit - do not gather by default, must say gather_facts: yes
+# implicit - gather by default, turn off with gather_facts: False
+# explicit - do not gather by default, must say gather_facts: True
 #gathering = implicit
 
 # This only affects the gathering done by a play's gather_facts directive,
diff --git a/deploy/ansible/group_vars/nuc/main.yml b/deploy/ansible/group_vars/nuc/main.yml
@@ -14,7 +14,7 @@
 k8s_engine: k3s
 
 image_pull_secret: aws-login-credentials
-use_airgap_images: no
+use_airgap_images: False
 
 # k8s namespaces
 app_namespace: thecombine
@@ -24,8 +24,8 @@ k8s_user: sillsdev
 ################################################
 # Support Tool Settings
 ################################################
-install_ip_viewer: yes
-install_combinectl: yes
+install_ip_viewer: True
+install_combinectl: True
 
 ################################################
 # Ingress configuration
@@ -41,12 +41,12 @@ k8s_dns_name: "{{ ansible_hostname }}"
 ################################################
 # Ethernet settings
 ################################################
-eth_optional: yes
+eth_optional: True
 
 ################################################
 # WiFi access point settings
 ################################################
-has_wifi: yes
+has_wifi: True
 ap_domain: thecombine.app
 ap_ssid: "{{ ansible_hostname }}_ap"
 ap_passphrase: "thecombine_pw"
@@ -56,5 +56,5 @@ ap_hostname: "{{ ansible_hostname }}"
 ################################################
 # hardware monitoring settings
 ################################################
-include_hw_monitoring: yes
+include_hw_monitoring: True
 history_days: 60
diff --git a/deploy/ansible/group_vars/server/main.yml b/deploy/ansible/group_vars/server/main.yml
@@ -10,7 +10,7 @@
 ################################################
 
 image_pull_secret: aws-login-credentials
-use_airgap_images: no
+use_airgap_images: False
 
 create_namespaces: []
 # k8s namespaces
@@ -19,8 +19,8 @@ app_namespace: thecombine
 ################################################
 # Support Tool Settings
 ################################################
-install_ip_viewer: no
-install_combinectl: no
+install_ip_viewer: False
+install_combinectl: False
 
 #######################################
 # Ingress configuration
@@ -29,9 +29,9 @@ ingress_namespace: ingress-nginx
 ################################################
 # WiFi access point settings
 ################################################
-has_wifi: no
+has_wifi: False
 
 ################################################
 # hardware monitoring settings
 ################################################
-include_hw_monitoring: no
+include_hw_monitoring: False
diff --git a/deploy/ansible/host_vars/localhost/main.yml b/deploy/ansible/host_vars/localhost/main.yml
@@ -8,7 +8,7 @@
 ################################################
 
 image_pull_secret: aws-login-credentials
-use_airgap_images: yes
+use_airgap_images: True
 
 # k8s namespaces
 app_namespace: thecombine
@@ -18,8 +18,8 @@ k8s_user: "{{ ansible_user_id }}"
 ################################################
 # Support Tool Settings
 ################################################
-install_ip_viewer: no
-install_combinectl: yes
+install_ip_viewer: False
+install_combinectl: True
 
 #######################################
 # Ingress configuration
@@ -35,20 +35,20 @@ k8s_dns_name: "local"
 ################################################
 # Ethernet settings
 ################################################
-eth_optional: yes
+eth_optional: True
 
 ################################################
 # WiFi access point settings
 ################################################
-has_wifi: yes
+has_wifi: True
 ap_domain: thecombine.app
 ap_ssid: "thecombine_ap"
 ap_passphrase: "thecombine_pw"
 ap_gateway: "10.10.10.1"
 ap_hostname: "local"
-test_wifi: no
+test_wifi: False
 ################################################
 # hardware monitoring settings
 ################################################
-include_hw_monitoring: no
+include_hw_monitoring: False
 history_days: 60
diff --git a/deploy/ansible/hosts.yml b/deploy/ansible/hosts.yml
@@ -5,7 +5,7 @@ all:
       ansible_connection: local
       kubecfgdir: local
       combine_server_name: local.thecombine.app
-      link_kubeconfig: yes
+      link_kubeconfig: True
   children:
     nuc:
       hosts:
diff --git a/deploy/ansible/playbook_desktop_setup.yml b/deploy/ansible/playbook_desktop_setup.yml
@@ -10,8 +10,8 @@
 
 - name: Configure hardware for The Combine
   hosts: localhost
-  gather_facts: yes
-  become: yes
+  gather_facts: True
+  become: True
 
   vars_files:
     - "vars/config_common.yml"
diff --git a/deploy/ansible/playbook_k3s_airgapped_files.yml b/deploy/ansible/playbook_k3s_airgapped_files.yml
@@ -15,8 +15,8 @@
 
 - name: Build package for k3s airgap installation
   hosts: localhost
-  gather_facts: yes
-  become: no
+  gather_facts: True
+  become: False
 
   vars_files:
     - "vars/k3s_versions.yml"
@@ -40,7 +40,7 @@
       shell:
         cmd: sha256sum --check --ignore-missing sha256sum-{{ cpu_arch }}.txt
         chdir: "{{ package_dir }}"
-      changed_when: no
+      changed_when: False
 
     - name: Download k3s install script
       get_url:
diff --git a/deploy/ansible/playbook_nuc_setup.yml b/deploy/ansible/playbook_nuc_setup.yml
@@ -11,8 +11,8 @@
 
 - name: Configure hardware for The Combine
   hosts: nuc
-  gather_facts: yes
-  become: yes
+  gather_facts: True
+  become: True
 
   vars_files:
     - "vars/config_common.yml"
@@ -21,8 +21,8 @@
   tasks:
     - name: Update packages
       apt:
-        update_cache: yes
-        upgrade: yes
+        update_cache: True
+        upgrade: True
 
     - name: Setup WiFi Access Point
       import_role:
diff --git a/deploy/ansible/roles/container_engine/tasks/main.yml b/deploy/ansible/roles/container_engine/tasks/main.yml
@@ -11,9 +11,9 @@
 ##############################################################
 - name: Update apt cache.
   apt:
-    update_cache: yes
+    update_cache: True
     cache_valid_time: 600
-  changed_when: no
+  changed_when: False
 
 - name: Install pre-requisite packages
   apt:
@@ -47,7 +47,7 @@
 - name: Install Docker Packages
   apt:
     name: "{{ container_packages }}"
-    update_cache: yes
+    update_cache: True
 
 - name: Check if reboot is required
   stat:
diff --git a/deploy/ansible/roles/k8s_install/handlers/main.yml b/deploy/ansible/roles/k8s_install/handlers/main.yml
@@ -2,6 +2,6 @@
 - name: Reload k3s
   systemd:
     name: k3s
-    daemon_reload: yes
-    enabled: yes
+    daemon_reload: True
+    enabled: True
     state: restarted
diff --git a/deploy/ansible/roles/k8s_install/tasks/k8s_remote_access.yml b/deploy/ansible/roles/k8s_install/tasks/k8s_remote_access.yml
@@ -8,11 +8,11 @@
   fetch:
     src: "{{ k8s_user_home.stdout }}/.kube/config"
     dest: "{{ kubecfg }}"
-    flat: yes
+    flat: True
 
 - name: Update kubeconfig file
   delegate_to: localhost
-  become: no
+  become: False
   block:
     - name: Restrict permissions to kubeconfig to owner
       file:
@@ -35,7 +35,7 @@
         state: present
         path: "{{ kubecfg }}"
         regexp: '^(\s+server: https:\/\/)[.0-9]+:(1?6443)'
-        backrefs: yes
+        backrefs: True
         line: '\1{{ k8s_dns_name }}:\2'
 
     - name: Replace 'default' cluster, user, etc with {{ kubecfgdir }}
diff --git a/deploy/ansible/roles/k8s_install/tasks/main.yml b/deploy/ansible/roles/k8s_install/tasks/main.yml
@@ -19,13 +19,13 @@
   shell: >
     getent passwd {{ k8s_user }} | awk -F: '{ print $6 }'
   register: k8s_user_home
-  changed_when: no
+  changed_when: False
 
 - name: Get user group id for {{ k8s_user }}
   shell: >
     getent passwd {{ k8s_user }} | awk -F: '{ print $4 }'
   register: k8s_user_group_id
-  changed_when: no
+  changed_when: False
 
 - name: Create .kube directories
   file:
@@ -67,7 +67,7 @@
   shell: >
     getent passwd {{ k8s_user }} | awk -F: '{ print $6 }'
   register: k8s_user_home
-  changed_when: no
+  changed_when: False
 
 - name: update profile
   lineinfile:
diff --git a/deploy/ansible/roles/monitor_hardware/tasks/main.yml b/deploy/ansible/roles/monitor_hardware/tasks/main.yml
@@ -30,5 +30,5 @@
 - name: Start monitoring service
   service:
     name: sysstat
-    enabled: yes
+    enabled: True
     state: started
diff --git a/deploy/ansible/roles/network_config/tasks/main.yml b/deploy/ansible/roles/network_config/tasks/main.yml
@@ -29,7 +29,7 @@
   community.general.nmcli:
     conn_name: "dummy-{{ virtual_if }}"
     ifname: "{{ virtual_if }}"
-    autoconnect: yes
+    autoconnect: True
     ip4: 172.16.1.23/16
     gw4: 172.16.1.23
     method4: "manual"
diff --git a/deploy/ansible/roles/support_tools/defaults/main.yml b/deploy/ansible/roles/support_tools/defaults/main.yml
@@ -2,5 +2,5 @@
 eth_update_period: 5s
 eth_update_program: /usr/local/bin/display-eth-addr
 
-install_ip_viewer: no
-install_combinectl: no
+install_ip_viewer: False
+install_combinectl: False
diff --git a/deploy/ansible/roles/support_tools/handlers/main.yml b/deploy/ansible/roles/support_tools/handlers/main.yml
@@ -3,8 +3,8 @@
   systemd:
     name: "{{ item }}"
     state: started
-    enabled: yes
-    daemon_reload: yes
+    enabled: True
+    daemon_reload: True
   with_items:
     - display-eth.service
     - display-eth.timer
diff --git a/deploy/ansible/roles/wifi_ap/defaults/main.yml b/deploy/ansible/roles/wifi_ap/defaults/main.yml
@@ -9,4 +9,4 @@ wifi_if_name: "{{ ansible_interfaces | join(' ') | regex_replace('^.*\\b(wl[a-z0
 ap_hosts_config: /etc/create_ap/create_ap.hosts
 create_ap_config: /etc/create_ap/create_ap.conf
 
-test_wifi: yes
+test_wifi: True
diff --git a/deploy/ansible/roles/wifi_ap/handlers/main.yml b/deploy/ansible/roles/wifi_ap/handlers/main.yml
@@ -2,8 +2,8 @@
 - name: Start create_ap
   systemd:
     name: create_ap
-    daemon_reload: yes
-    enabled: yes
+    daemon_reload: True
+    enabled: True
     state: started
 
 - name: Restart create_ap
diff --git a/deploy/ansible/roles/wifi_ap/tasks/install.yml b/deploy/ansible/roles/wifi_ap/tasks/install.yml
@@ -9,7 +9,7 @@
       - iw
       - dnsmasq
       - iptables
-    update_cache: yes
+    update_cache: True
     cache_valid_time: 3600
     state: present
   notify: Start create_ap
diff --git a/deploy/ansible/vars/config_common.yml b/deploy/ansible/vars/config_common.yml
@@ -1,9 +1,9 @@
 ---
 # Configure logging
-combine_use_syslog: yes
+combine_use_syslog: True
 
 # Configure whether airgap images should be installed on target
-install_airgap_images: no
+install_airgap_images: False
 
 # Kubernetes local Working directories
 k8s_working_dir: "{{ lookup('env', 'HOME') }}/.kube/{{ kubecfgdir }}"
diff --git a/deploy/scripts/install-combine.sh b/deploy/scripts/install-combine.sh
@@ -81,7 +81,7 @@ install-kubernetes () {
   # Set -e/--extra-vars for ansible-playbook
   EXTRA_VARS="-e k8s_user=$(whoami)"
   if [ -d "${DEPLOY_DIR}/airgap-images" ] ; then
-    EXTRA_VARS="${EXTRA_VARS} -e install_airgap_images=yes"
+    EXTRA_VARS="${EXTRA_VARS} -e install_airgap_images=True"
   fi
   
   ansible-playbook playbook_desktop_setup.yml -K ${EXTRA_VARS} $(((DEBUG == 1)) && echo "-vv")
